patch 'net/i40e: move filter config to flow create' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Fri Feb 20 15:56:42 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/22/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/3a0bd215e4f8ed91eb3c7b5d0fa9a70aa26721a0
Thanks.
Luca Boccassi
---
>From 3a0bd215e4f8ed91eb3c7b5d0fa9a70aa26721a0 Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Fri, 13 Feb 2026 09:10:08 +0000
Subject: [PATCH] net/i40e: move filter config to flow create
[ upstream commit 59acde9b24725d0bc3ad745773749c3b798c7896 ]
Currently, FDIR filter parsing function will modify FDIR state after a
successful match. However, this function is called from both flow create
and flow validate, which results in the driver modifying FDIR state
after a flow validate call. Move the FDIR config to flow create.
Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
---
drivers/net/i40e/i40e_flow.c | 51 ++++++++++++++++--------------------
1 file changed, 23 insertions(+), 28 deletions(-)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index cd598431e1..c46d26b41f 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -2552,9 +2552,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
struct rte_flow_error *error,
union i40e_filter_t *filter)
{
- struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
- struct i40e_fdir_filter_conf *fdir_filter =
- &filter->fdir_filter;
+ struct i40e_fdir_filter_conf *fdir_filter = &filter->fdir_filter;
int ret;
ret = i40e_flow_parse_fdir_pattern(dev, pattern, error, fdir_filter);
@@ -2571,32 +2569,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
cons_filter_type = RTE_ETH_FILTER_FDIR;
- if (pf->fdir.fdir_vsi == NULL) {
- /* Enable fdir when fdir flow is added at first time. */
- ret = i40e_fdir_setup(pf);
- if (ret != I40E_SUCCESS) {
- rte_flow_error_set(error, ENOTSUP,
- RTE_FLOW_ERROR_TYPE_HANDLE,
- NULL, "Failed to setup fdir.");
- return -rte_errno;
- }
- ret = i40e_fdir_configure(dev);
- if (ret < 0) {
- rte_flow_error_set(error, ENOTSUP,
- RTE_FLOW_ERROR_TYPE_HANDLE,
- NULL, "Failed to configure fdir.");
- goto err;
- }
- }
-
- /* If create the first fdir rule, enable fdir check for rx queues */
- if (TAILQ_EMPTY(&pf->fdir.fdir_list))
- i40e_fdir_rx_proc_enable(dev, 1);
-
return 0;
-err:
- i40e_fdir_teardown(pf);
- return -rte_errno;
}
/* Parse to get the action info of a tunnel filter
@@ -3922,6 +3895,28 @@ i40e_flow_create(struct rte_eth_dev *dev,
return NULL;
if (cons_filter_type == RTE_ETH_FILTER_FDIR) {
+ /* if this is the first time we're creating an fdir flow */
+ if (pf->fdir.fdir_vsi == NULL) {
+ ret = i40e_fdir_setup(pf);
+ if (ret != I40E_SUCCESS) {
+ rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_HANDLE,
+ NULL, "Failed to setup fdir.");
+ return NULL;
+ }
+ ret = i40e_fdir_configure(dev);
+ if (ret < 0) {
+ rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_HANDLE,
+ NULL, "Failed to configure fdir.");
+ i40e_fdir_teardown(pf);
+ return NULL;
+ }
+ }
+ /* If create the first fdir rule, enable fdir check for rx queues */
+ if (TAILQ_EMPTY(&pf->fdir.fdir_list))
+ i40e_fdir_rx_proc_enable(dev, 1);
+
flow = i40e_fdir_entry_pool_get(fdir_info);
if (flow == NULL) {
rte_flow_error_set(error, ENOBUFS,
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-02-20 14:55:47.052376332 +0000
+++ 0100-net-i40e-move-filter-config-to-flow-create.patch 2026-02-20 14:55:43.352193583 +0000
@@ -1 +1 @@
-From 59acde9b24725d0bc3ad745773749c3b798c7896 Mon Sep 17 00:00:00 2001
+From 3a0bd215e4f8ed91eb3c7b5d0fa9a70aa26721a0 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 59acde9b24725d0bc3ad745773749c3b798c7896 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -17 +18 @@
- drivers/net/intel/i40e/i40e_flow.c | 51 ++++++++++++++----------------
+ drivers/net/i40e/i40e_flow.c | 51 ++++++++++++++++--------------------
@@ -20,5 +21,5 @@
-diff --git a/drivers/net/intel/i40e/i40e_flow.c b/drivers/net/intel/i40e/i40e_flow.c
-index f130f53ae0..193b1b6725 100644
---- a/drivers/net/intel/i40e/i40e_flow.c
-+++ b/drivers/net/intel/i40e/i40e_flow.c
-@@ -2551,9 +2551,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
+diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
+index cd598431e1..c46d26b41f 100644
+--- a/drivers/net/i40e/i40e_flow.c
++++ b/drivers/net/i40e/i40e_flow.c
+@@ -2552,9 +2552,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
@@ -35 +36 @@
-@@ -2570,32 +2568,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
+@@ -2571,32 +2569,7 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
@@ -68 +69 @@
-@@ -3921,6 +3894,28 @@ i40e_flow_create(struct rte_eth_dev *dev,
+@@ -3922,6 +3895,28 @@ i40e_flow_create(struct rte_eth_dev *dev,
More information about the stable
mailing list