patch 'net/bnxt: fix build with GCC 16' has been queued to stable release 25.11.1
Kevin Traynor
ktraynor at redhat.com
Thu Feb 26 14:08:46 CET 2026
Hi,
FYI, your patch has been queued to stable release 25.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/02/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/fab8ad2a0ee16a8d4be76127c78865e9b41d303f
Thanks.
Kevin
---
>From fab8ad2a0ee16a8d4be76127c78865e9b41d303f Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Fri, 14 Nov 2025 10:52:40 -0800
Subject: [PATCH] net/bnxt: fix build with GCC 16
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[ upstream commit bad04ef83fc3b367c0e297ea46394f7c6b138162 ]
With gcc-16 it inlines a lot more code and creates a warnings
where it thinks it might be manipulating bits that are not set.
It looks like this is because the bits in control word (cword)
in theory could be larger than the variable. Should not
be possible because wc_ctl_size_bits is only set to 3, 16, or 32
but that happens outside of the scope of these functions.
Resolve by adding bounds check which compiler sees and knows
the loop will only see those bits.
In function ‘ulp_bs_push_msb’,
inlined from ‘ulp_blob_push’
at drivers/net/bnxt/tf_ulp/ulp_utils.h:407:8,
inlined from ‘ulp_blob_push_32’
at drivers/net/bnxt/tf_ulp/ulp_utils.h:551:7,
inlined from ‘ulp_mapper_wc_tcam_tbl_dyn_post_process’
at drivers/net/bnxt/tf_ulp/ulp_mapper.c:2487:9:
drivers/net/bnxt/tf_ulp/ulp_utils.h:336:17:
warning: ‘cword’ may be used uninitialized [-Wmaybe-uninitialized]
336 | ulp_bs_put_msb(bs, pos, 8, val[i]);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘ulp_mapper_wc_tcam_tbl_dyn_post_process’:
drivers/net/bnxt/tf_ulp/ulp_mapper.c:2443:18: note: ‘cword’ declared here
2443 | uint32_t cword, i, rc;
| ^~~~~
Bugzilla ID: 1821
Fixes: 3fe124d2536c ("net/bnxt: support Thor platform")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
drivers/net/bnxt/tf_ulp/ulp_mapper.c | 5 +++++
drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c | 4 ++++
2 files changed, 9 insertions(+)
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c
index 0ff952950b..960cdda311 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c
@@ -2447,4 +2447,9 @@ ulp_mapper_wc_tcam_tbl_dyn_post_process(struct bnxt_ulp_device_params *dparms,
slice_width = dparms->wc_slice_width;
clen = dparms->wc_ctl_size_bits;
+ if (clen > 32) {
+ BNXT_DRV_DBG(ERR, "Key size bits %d too large\n", clen);
+ return -EINVAL;
+ }
+
max_slices = dparms->wc_max_slices;
blen = ulp_blob_data_len_get(key);
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c b/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
index f99698a1d8..2d89f10d5e 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
@@ -91,4 +91,8 @@ ulp_mapper_tfc_wc_tcam_post_process(struct bnxt_ulp_device_params *dparms,
slice_width = dparms->wc_slice_width;
clen = dparms->wc_ctl_size_bits;
+ if (clen > 32) {
+ BNXT_DRV_DBG(ERR, "Key size bits %d too large\n", clen);
+ return -EINVAL;
+ }
max_slices = dparms->wc_max_slices;
blen = ulp_blob_data_len_get(key);
--
2.53.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-02-26 10:16:48.842966786 +0000
+++ 0044-net-bnxt-fix-build-with-GCC-16.patch 2026-02-26 10:16:46.957459264 +0000
@@ -1 +1 @@
-From bad04ef83fc3b367c0e297ea46394f7c6b138162 Mon Sep 17 00:00:00 2001
+From fab8ad2a0ee16a8d4be76127c78865e9b41d303f Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit bad04ef83fc3b367c0e297ea46394f7c6b138162 ]
+
@@ -37 +38,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list