patch 'dma/dpaa2: propagate removal error' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Jul 6 12:19:53 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/05/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/93982879f99b0bd1cae51f8478c926d294b97191
Thanks.
Luca Boccassi
---
>From 93982879f99b0bd1cae51f8478c926d294b97191 Mon Sep 17 00:00:00 2001
From: Md Shofiqul Islam <shofiqtest at gmail.com>
Date: Sat, 16 May 2026 14:08:28 +0300
Subject: [PATCH] dma/dpaa2: propagate removal error
[ upstream commit 611ef29e2c768bcede197996ddd9c5a37cf1a243 ]
dpaa2_qdma_remove() checked the return value of rte_dma_pmd_release()
and logged an error on failure, but then unconditionally returned 0,
hiding the failure from fslmc_bus_unplug() and any higher-level
caller. A device-cleanup failure was silently swallowed.
Return the actual error code so that callers can detect and handle
removal failures correctly.
Bugzilla ID: 1914
Fixes: 8caf8427f85a ("dma/dpaa2: introduce driver skeleton")
Signed-off-by: Md Shofiqul Islam <shofiqtest at gmail.com>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
drivers/dma/dpaa2/dpaa2_qdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c
index 3c9a7b5485..98106ab1c2 100644
--- a/drivers/dma/dpaa2/dpaa2_qdma.c
+++ b/drivers/dma/dpaa2/dpaa2_qdma.c
@@ -1740,7 +1740,7 @@ dpaa2_qdma_remove(struct rte_dpaa2_device *dpaa2_dev)
if (ret)
DPAA2_QDMA_ERR("Device cleanup failed");
- return 0;
+ return ret;
}
static struct rte_dpaa2_driver rte_dpaa2_qdma_pmd;
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-03 12:55:46.767279695 +0100
+++ 0001-dma-dpaa2-propagate-removal-error.patch 2026-07-03 12:55:46.574571466 +0100
@@ -1 +1 @@
-From 611ef29e2c768bcede197996ddd9c5a37cf1a243 Mon Sep 17 00:00:00 2001
+From 93982879f99b0bd1cae51f8478c926d294b97191 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 611ef29e2c768bcede197996ddd9c5a37cf1a243 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index beca464c72..f7d94bb799 100644
+index 3c9a7b5485..98106ab1c2 100644
@@ -28 +29 @@
-@@ -1739,7 +1739,7 @@ dpaa2_qdma_remove(struct rte_dpaa2_device *dpaa2_dev)
+@@ -1740,7 +1740,7 @@ dpaa2_qdma_remove(struct rte_dpaa2_device *dpaa2_dev)
More information about the stable
mailing list