patch 'net/bonding: check mode before setting dedicated queues' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Jul 6 12:20:46 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/05/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/ff2a53cc335dddb924ca9558bd317ab1a0e16ac2
Thanks.
Luca Boccassi
---
>From ff2a53cc335dddb924ca9558bd317ab1a0e16ac2 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 28 May 2026 16:36:31 -0700
Subject: [PATCH] net/bonding: check mode before setting dedicated queues
[ upstream commit 8a13d4a24cda0807ceaa7dfd94bdf834facc0990 ]
The calls to enable and disable dedicated queues are missing
check for mode.
Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index cb71515bff..552aac6167 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -1715,7 +1715,6 @@ bond_mode_8023ad_ext_periodic_cb(void *arg)
int
rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
{
- int retval = 0;
struct rte_eth_dev *dev;
struct bond_dev_private *internals;
@@ -1732,16 +1731,18 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
if (dev->data->dev_started)
return -1;
+ if (internals->mode != BONDING_MODE_8023AD)
+ return -1;
+
internals->mode4.dedicated_queues.enabled = 1;
bond_ethdev_mode_set(dev, internals->mode);
- return retval;
+ return 0;
}
int
rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
{
- int retval = 0;
struct rte_eth_dev *dev;
struct bond_dev_private *internals;
@@ -1755,9 +1756,12 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
if (dev->data->dev_started)
return -1;
+ if (internals->mode != BONDING_MODE_8023AD)
+ return -1;
+
internals->mode4.dedicated_queues.enabled = 0;
bond_ethdev_mode_set(dev, internals->mode);
- return retval;
+ return 0;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-03 12:55:48.734450795 +0100
+++ 0054-net-bonding-check-mode-before-setting-dedicated-queu.patch 2026-07-03 12:55:46.694574611 +0100
@@ -1 +1 @@
-From 8a13d4a24cda0807ceaa7dfd94bdf834facc0990 Mon Sep 17 00:00:00 2001
+From ff2a53cc335dddb924ca9558bd317ab1a0e16ac2 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8a13d4a24cda0807ceaa7dfd94bdf834facc0990 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index eba713e381..d1f30229d0 100644
+index cb71515bff..552aac6167 100644
@@ -22 +23 @@
-@@ -1725,7 +1725,6 @@ RTE_EXPORT_SYMBOL(rte_eth_bond_8023ad_dedicated_queues_enable)
+@@ -1715,7 +1715,6 @@ bond_mode_8023ad_ext_periodic_cb(void *arg)
@@ -30 +31 @@
-@@ -1742,17 +1741,19 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
+@@ -1732,16 +1731,18 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
@@ -44 +44,0 @@
- RTE_EXPORT_SYMBOL(rte_eth_bond_8023ad_dedicated_queues_disable)
@@ -52 +52 @@
-@@ -1766,9 +1767,12 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
+@@ -1755,9 +1756,12 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
More information about the stable
mailing list