patch 'net/enic: fix null dereference in flow mask check' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Jul 13 19:17:44 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/15/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/ab89db9d9fd50d0a810ed0aea3b9d831c79decc2
Thanks.
Luca Boccassi
---
>From ab89db9d9fd50d0a810ed0aea3b9d831c79decc2 Mon Sep 17 00:00:00 2001
From: Alexey Simakov <bigalex934 at gmail.com>
Date: Tue, 7 Jul 2026 11:58:31 +0300
Subject: [PATCH] net/enic: fix null dereference in flow mask check
[ upstream commit 1e267033c1f67cf7ed6f01d449297ff88f3e341d ]
The functions enic_copy_item_ipv4_v1(), enic_copy_item_udp_v1(), and
enic_copy_item_tcp_v1() each initialize a local 'mask' variable from
item->mask and substitute it with a hardcoded mask if NULL. However,
the subsequent mask_exact_match() call uses item->mask directly
instead of the local 'mask' variable, which will dereference NULL
when item->mask is NULL.
Use the local 'mask' variable (which has been validated and possibly
substituted) instead of item->mask.
Fixes: aa3d2ff82198 ("net/enic: flow API for Legacy NICs")
Signed-off-by: Alexey Simakov <bigalex934 at gmail.com>
Acked-by: Hyong Youb Kim <hyonkim at cisco.com>
---
.mailmap | 1 +
drivers/net/enic/enic_flow.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/.mailmap b/.mailmap
index b7badeefb4..d10d372387 100644
--- a/.mailmap
+++ b/.mailmap
@@ -71,6 +71,7 @@ Alex Rosenbaum <alexr at nvidia.com> <alexr at mellanox.com>
Alex Vesker <valex at nvidia.com>
Alex Wang <alex at awakenetworks.com>
Alex Zelezniak <alexz at att.com>
+Alexey Simakov <bigalex934 at gmail.com>
Alfredo Cardigliano <cardigliano at ntop.org>
Ali Alnubani <alialnu at nvidia.com> <alialnu at mellanox.com>
Ali Volkan Atli <volkan.atli at argela.com.tr>
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index 758000ea21..539b0eb725 100644
--- a/drivers/net/enic/enic_flow.c
+++ b/drivers/net/enic/enic_flow.c
@@ -407,7 +407,7 @@ enic_copy_item_ipv4_v1(struct copy_item_args *arg)
/* check that the supplied mask exactly matches capability */
if (!mask_exact_match((const uint8_t *)&supported_mask,
- (const uint8_t *)item->mask, sizeof(*mask))) {
+ (const uint8_t *)mask, sizeof(*mask))) {
ENICPMD_LOG(ERR, "IPv4 exact match mask");
return ENOTSUP;
}
@@ -445,7 +445,7 @@ enic_copy_item_udp_v1(struct copy_item_args *arg)
/* check that the supplied mask exactly matches capability */
if (!mask_exact_match((const uint8_t *)&supported_mask,
- (const uint8_t *)item->mask, sizeof(*mask))) {
+ (const uint8_t *)mask, sizeof(*mask))) {
ENICPMD_LOG(ERR, "UDP exact match mask");
return ENOTSUP;
}
@@ -484,7 +484,7 @@ enic_copy_item_tcp_v1(struct copy_item_args *arg)
/* check that the supplied mask exactly matches capability */
if (!mask_exact_match((const uint8_t *)&supported_mask,
- (const uint8_t *)item->mask, sizeof(*mask))) {
+ (const uint8_t *)mask, sizeof(*mask))) {
ENICPMD_LOG(ERR, "TCP exact match mask");
return ENOTSUP;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-13 18:17:05.759757476 +0100
+++ 0004-net-enic-fix-null-dereference-in-flow-mask-check.patch 2026-07-13 18:17:05.574282834 +0100
@@ -1 +1 @@
-From 1e267033c1f67cf7ed6f01d449297ff88f3e341d Mon Sep 17 00:00:00 2001
+From ab89db9d9fd50d0a810ed0aea3b9d831c79decc2 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1e267033c1f67cf7ed6f01d449297ff88f3e341d ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index 05a55c0bd6..b430aa8403 100644
+index b7badeefb4..d10d372387 100644
@@ -30,4 +31,4 @@
-@@ -72,6 +72,7 @@ Alexander Solganik <solganik at gmail.com>
- Alexander V Gutkin <alexander.v.gutkin at intel.com>
- Alexandre Ferrieux <alexandre.ferrieux at orange.com>
- Alexey Kardashevskiy <aik at ozlabs.ru>
+@@ -71,6 +71,7 @@ Alex Rosenbaum <alexr at nvidia.com> <alexr at mellanox.com>
+ Alex Vesker <valex at nvidia.com>
+ Alex Wang <alex at awakenetworks.com>
+ Alex Zelezniak <alexz at att.com>
More information about the stable
mailing list