patch 'app/testpmd: fix flow job list double-free on reattach' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Jul 13 19:17:53 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/15/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/14d9ce6ebc23736498d8ba290b7e84b23181a69d
Thanks.
Luca Boccassi
---
>From 14d9ce6ebc23736498d8ba290b7e84b23181a69d Mon Sep 17 00:00:00 2001
From: Shani Peretz <shperetz at nvidia.com>
Date: Mon, 6 Jul 2026 14:52:48 +0300
Subject: [PATCH] app/testpmd: fix flow job list double-free on reattach
[ upstream commit a3fe115b2b971d77c65799eee9c90526dfc8129d ]
When a port is closed via close_port(), port_free_job_list() frees the
job_list but does not NULL the pointer or reset queue_nb. If the port
is later reattached and "flow configure" is issued, port_flow_configure()
frees the dangling job_list pointer, causing a double-free.
Fix this by setting job_list to NULL and resetting queue_nb to zero in
port_free_job_list() after freeing.
Fixes: 7fadc8039588 ("app/testpmd: fix memory leak in port flow configure")
Signed-off-by: Shani Peretz <shperetz at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
app/test-pmd/testpmd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 8f2f3f5386..c292358a90 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3251,6 +3251,8 @@ port_free_job_list(portid_t pi)
{
struct rte_port *port = &ports[pi];
free(port->job_list);
+ port->job_list = NULL;
+ port->queue_nb = 0;
}
static void
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-13 18:17:06.068426397 +0100
+++ 0013-app-testpmd-fix-flow-job-list-double-free-on-reattac.patch 2026-07-13 18:17:05.582282980 +0100
@@ -1 +1 @@
-From a3fe115b2b971d77c65799eee9c90526dfc8129d Mon Sep 17 00:00:00 2001
+From 14d9ce6ebc23736498d8ba290b7e84b23181a69d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a3fe115b2b971d77c65799eee9c90526dfc8129d ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 2ba868d371..cab2fa1556 100644
+index 8f2f3f5386..c292358a90 100644
@@ -27 +28 @@
-@@ -3365,6 +3365,8 @@ port_free_job_list(portid_t pi)
+@@ -3251,6 +3251,8 @@ port_free_job_list(portid_t pi)
More information about the stable
mailing list