patch 'net/dpaa: fix device remove' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Jul 20 19:03:59 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/22/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/8b8a91c87489107cc79a27cc17ffbfe15c47b8d6
Thanks.
Luca Boccassi
---
>From 8b8a91c87489107cc79a27cc17ffbfe15c47b8d6 Mon Sep 17 00:00:00 2001
From: Gagandeep Singh <g.singh at nxp.com>
Date: Mon, 13 Jul 2026 15:47:47 +0530
Subject: [PATCH] net/dpaa: fix device remove
[ upstream commit c468b4374d92c32222a796f3ddffd6b741012d36 ]
Add a check to avoid closing a device that is already closed,
preventing a double-close condition during device removal.
Note: this also removes the explicit dpaa_finish() call that was
made at last-device remove time (!dpaa_valid_dev). dpaa_finish() is
registered as RTE_FINI_PRIO(dpaa_finish, 103) and will still run at
process exit, so for the normal run-then-exit path behaviour is
unchanged. For a remove-all-then-re-probe scenario, is_global_init
will remain set until exit; re-probe in a running process is not a
supported use case for this driver.
Fixes: 78ea4b4fcb52 ("bus/dpaa: improve cleanup")
Signed-off-by: Gagandeep Singh <g.singh at nxp.com>
---
drivers/net/dpaa/dpaa_ethdev.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 8f63dc80d2..9cb5f0ee75 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -2708,18 +2708,20 @@ static int
rte_dpaa_remove(struct rte_dpaa_device *dpaa_dev)
{
struct rte_eth_dev *eth_dev;
- int ret;
+ int ret = 0;
PMD_INIT_FUNC_TRACE();
eth_dev = dpaa_dev->eth_dev;
- dpaa_eth_dev_close(eth_dev);
- ret = rte_eth_dev_release_port(eth_dev);
+ ret = dpaa_eth_dev_close(eth_dev);
+ if (eth_dev->state != RTE_ETH_DEV_UNUSED) {
+ dpaa_eth_dev_close(eth_dev);
+ ret = rte_eth_dev_release_port(eth_dev);
+ }
dpaa_valid_dev--;
- if (!dpaa_valid_dev) {
+ if (!dpaa_valid_dev)
rte_mempool_free(dpaa_tx_sg_pool);
- dpaa_finish();
- }
+
return ret;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-20 18:03:26.065385486 +0100
+++ 0015-net-dpaa-fix-device-remove.patch 2026-07-20 18:03:25.512443363 +0100
@@ -1 +1 @@
-From c468b4374d92c32222a796f3ddffd6b741012d36 Mon Sep 17 00:00:00 2001
+From 8b8a91c87489107cc79a27cc17ffbfe15c47b8d6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c468b4374d92c32222a796f3ddffd6b741012d36 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index f6d9dd6248..4dc4d1f10c 100644
+index 8f63dc80d2..9cb5f0ee75 100644
@@ -29 +30 @@
-@@ -2672,18 +2672,20 @@ static int
+@@ -2708,18 +2708,20 @@ static int
@@ -38 +39 @@
- eth_dev = rte_eth_dev_allocated(dpaa_dev->device.name);
+ eth_dev = dpaa_dev->eth_dev;
More information about the stable
mailing list