patch 'net/af_packet: fix indentation' has been queued to stable release 25.11.3
Kevin Traynor
ktraynor at redhat.com
Thu Jul 23 19:14:41 CEST 2026
Hi,
FYI, your patch has been queued to stable release 25.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/27/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/484556d2920dac1b185952c2a7d557d283d91377
Thanks.
Kevin
---
>From 484556d2920dac1b185952c2a7d557d283d91377 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 29 Apr 2026 11:19:00 -0700
Subject: [PATCH] net/af_packet: fix indentation
[ upstream commit 3216387d58c86202c2adf22b6eefed9014ab4061 ]
DPDK code is supposed to be indented with TABS not spaces.
Also, used "unsigned int" to keep checkpatch happy.
Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/af_packet/rte_eth_af_packet.c | 64 +++++++++++------------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index 837d6f1022..6ed601be95 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -79,5 +79,5 @@ struct __rte_cache_aligned pkt_tx_queue {
struct pmd_internals {
- unsigned nb_queues;
+ unsigned int nb_queues;
int if_index;
@@ -548,5 +548,5 @@ eth_dev_close(struct rte_eth_dev *dev)
static int
eth_link_update(struct rte_eth_dev *dev,
- int wait_to_complete __rte_unused)
+ int wait_to_complete __rte_unused)
{
const struct pmd_internals *internals = dev->data->dev_private;
@@ -568,9 +568,9 @@ eth_link_update(struct rte_eth_dev *dev,
static int
eth_rx_queue_setup(struct rte_eth_dev *dev,
- uint16_t rx_queue_id,
- uint16_t nb_rx_desc __rte_unused,
- unsigned int socket_id __rte_unused,
- const struct rte_eth_rxconf *rx_conf __rte_unused,
- struct rte_mempool *mb_pool)
+ uint16_t rx_queue_id,
+ uint16_t nb_rx_desc __rte_unused,
+ unsigned int socket_id __rte_unused,
+ const struct rte_eth_rxconf *rx_conf __rte_unused,
+ struct rte_mempool *mb_pool)
{
struct pmd_internals *internals = dev->data->dev_private;
@@ -603,8 +603,8 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
static int
eth_tx_queue_setup(struct rte_eth_dev *dev,
- uint16_t tx_queue_id,
- uint16_t nb_tx_desc __rte_unused,
- unsigned int socket_id __rte_unused,
- const struct rte_eth_txconf *tx_conf __rte_unused)
+ uint16_t tx_queue_id,
+ uint16_t nb_tx_desc __rte_unused,
+ unsigned int socket_id __rte_unused,
+ const struct rte_eth_txconf *tx_conf __rte_unused)
{
@@ -733,6 +733,6 @@ static const struct eth_dev_ops ops = {
static int
open_packet_iface(const char *key __rte_unused,
- const char *value __rte_unused,
- void *extra_args)
+ const char *value __rte_unused,
+ void *extra_args)
{
int *sockfd = extra_args;
@@ -797,15 +797,15 @@ get_fanout(const char *fanout_mode, int if_index)
static int
rte_pmd_init_internals(struct rte_vdev_device *dev,
- const int sockfd,
- const unsigned nb_queues,
- unsigned int blocksize,
- unsigned int blockcnt,
- unsigned int framesize,
- unsigned int framecnt,
+ const int sockfd,
+ const unsigned int nb_queues,
+ unsigned int blocksize,
+ unsigned int blockcnt,
+ unsigned int framesize,
+ unsigned int framecnt,
unsigned int qdisc_bypass,
const char *fanout_mode,
- struct pmd_internals **internals,
- struct rte_eth_dev **eth_dev,
- struct rte_kvargs *kvlist)
+ struct pmd_internals **internals,
+ struct rte_eth_dev **eth_dev,
+ struct rte_kvargs *kvlist)
{
const char *name = rte_vdev_device_name(dev);
@@ -833,5 +833,5 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
PMD_LOG(ERR,
"%s: no interface specified for AF_PACKET ethdev",
- name);
+ name);
return -1;
}
@@ -842,5 +842,5 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
*internals = rte_zmalloc_socket(name, sizeof(**internals),
- 0, numa_node);
+ 0, numa_node);
if (*internals == NULL)
return -1;
@@ -1083,6 +1083,6 @@ free_internals:
static int
rte_eth_from_packet(struct rte_vdev_device *dev,
- int const *sockfd,
- struct rte_kvargs *kvlist)
+ int const *sockfd,
+ struct rte_kvargs *kvlist)
{
const char *name = rte_vdev_device_name(dev);
@@ -1115,5 +1115,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
PMD_LOG(ERR,
"%s: invalid qpairs value",
- name);
+ name);
return -1;
}
@@ -1125,5 +1125,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
PMD_LOG(ERR,
"%s: invalid blocksize value",
- name);
+ name);
return -1;
}
@@ -1135,5 +1135,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
PMD_LOG(ERR,
"%s: invalid framesize value",
- name);
+ name);
return -1;
}
@@ -1145,5 +1145,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
PMD_LOG(ERR,
"%s: invalid framecount value",
- name);
+ name);
return -1;
}
@@ -1169,5 +1169,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
PMD_LOG(ERR,
"%s: AF_PACKET MMAP frame size exceeds block size!",
- name);
+ name);
return -1;
}
@@ -1244,5 +1244,5 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev)
ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG,
- &open_packet_iface, &sockfd);
+ &open_packet_iface, &sockfd);
if (ret < 0)
goto exit;
--
2.55.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-23 17:57:59.219100405 +0100
+++ 0018-net-af_packet-fix-indentation.patch 2026-07-23 17:57:58.635146365 +0100
@@ -1 +1 @@
-From 3216387d58c86202c2adf22b6eefed9014ab4061 Mon Sep 17 00:00:00 2001
+From 484556d2920dac1b185952c2a7d557d283d91377 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3216387d58c86202c2adf22b6eefed9014ab4061 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 0ee94e71ea..8303ff5ca9 100644
+index 837d6f1022..6ed601be95 100644
@@ -21 +22 @@
-@@ -80,5 +80,5 @@ struct __rte_cache_aligned pkt_tx_queue {
+@@ -79,5 +79,5 @@ struct __rte_cache_aligned pkt_tx_queue {
@@ -28 +29 @@
-@@ -603,5 +603,5 @@ eth_dev_close(struct rte_eth_dev *dev)
+@@ -548,5 +548,5 @@ eth_dev_close(struct rte_eth_dev *dev)
@@ -35 +36 @@
-@@ -623,9 +623,9 @@ eth_link_update(struct rte_eth_dev *dev,
+@@ -568,9 +568,9 @@ eth_link_update(struct rte_eth_dev *dev,
@@ -50 +51 @@
-@@ -661,8 +661,8 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
+@@ -603,8 +603,8 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
@@ -63 +64 @@
-@@ -791,6 +791,6 @@ static const struct eth_dev_ops ops = {
+@@ -733,6 +733,6 @@ static const struct eth_dev_ops ops = {
@@ -72 +73 @@
-@@ -855,15 +855,15 @@ get_fanout(const char *fanout_mode, int if_index)
+@@ -797,15 +797,15 @@ get_fanout(const char *fanout_mode, int if_index)
@@ -97 +98 @@
-@@ -891,5 +891,5 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
+@@ -833,5 +833,5 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
@@ -104 +105 @@
-@@ -900,5 +900,5 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
+@@ -842,5 +842,5 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
@@ -111 +112 @@
-@@ -1141,6 +1141,6 @@ free_internals:
+@@ -1083,6 +1083,6 @@ free_internals:
@@ -120 +121 @@
-@@ -1173,5 +1173,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
+@@ -1115,5 +1115,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
@@ -127 +128 @@
-@@ -1183,5 +1183,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
+@@ -1125,5 +1125,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
@@ -134 +135 @@
-@@ -1193,5 +1193,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
+@@ -1135,5 +1135,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
@@ -141 +142 @@
-@@ -1203,5 +1203,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
+@@ -1145,5 +1145,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
@@ -148 +149 @@
-@@ -1227,5 +1227,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
+@@ -1169,5 +1169,5 @@ rte_eth_from_packet(struct rte_vdev_device *dev,
@@ -155 +156 @@
-@@ -1302,5 +1302,5 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev)
+@@ -1244,5 +1244,5 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev)
More information about the stable
mailing list