patch 'net/failsafe: fix hotplug mutex for multi-process' has been queued to stable release 25.11.3
Kevin Traynor
ktraynor at redhat.com
Thu Jul 23 19:14:45 CEST 2026
Hi,
FYI, your patch has been queued to stable release 25.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/27/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/63fb2bac73a4765934488e9a637ccf79ed1475fb
Thanks.
Kevin
---
>From 63fb2bac73a4765934488e9a637ccf79ed1475fb Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 29 Apr 2026 11:46:40 -0700
Subject: [PATCH] net/failsafe: fix hotplug mutex for multi-process
[ upstream commit c0b8fc5e4f6a9bf5447f2b9c55636576e962ed9c ]
The failsafe driver supports secondary process attachment via
rte_eth_dev_attach_secondary() in rte_pmd_failsafe_probe(). The
hotplug_mutex protects shared state but was initialized without
PTHREAD_PROCESS_SHARED.
The mutex is also recursive, so the EAL helper does not fit; set the
attribute alongside the recursive type. Also add the missing
pthread_mutexattr_destroy() call.
Bugzilla ID: 662
Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Konstantin Ananyev <konstantin.ananyev at huawei.com>
---
drivers/net/failsafe/failsafe.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 3e590d38f7..aa3fe53b22 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -145,9 +145,18 @@ fs_mutex_init(struct fs_priv *priv)
ret = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);
if (ret) {
- ERROR("Cannot set mutex type - %s", strerror(ret));
- return ret;
+ ERROR("Cannot set mutex recursive - %s", strerror(ret));
+ goto out;
}
+ /* Allow mutex to be shared between processes. */
+ ret = pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
+ if (ret) {
+ ERROR("Cannot set mutex pshared - %s", strerror(ret));
+ goto out;
+ }
+ pthread_mutex_init(&priv->hotplug_mutex, &attr);
- return pthread_mutex_init(&priv->hotplug_mutex, &attr);
+out:
+ pthread_mutexattr_destroy(&attr);
+ return ret;
}
--
2.55.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-23 17:57:59.327783096 +0100
+++ 0022-net-failsafe-fix-hotplug-mutex-for-multi-process.patch 2026-07-23 17:57:58.636985865 +0100
@@ -1 +1 @@
-From c0b8fc5e4f6a9bf5447f2b9c55636576e962ed9c Mon Sep 17 00:00:00 2001
+From 63fb2bac73a4765934488e9a637ccf79ed1475fb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c0b8fc5e4f6a9bf5447f2b9c55636576e962ed9c ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list