patch 'net/ice: fix TM hierarchy deletion' has been queued to stable release 25.11.3
Kevin Traynor
ktraynor at redhat.com
Thu Jul 23 19:15:13 CEST 2026
Hi,
FYI, your patch has been queued to stable release 25.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/27/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/0bcb7d28eafe3f3d9b0baecf961ce95ac0031503
Thanks.
Kevin
---
>From 0bcb7d28eafe3f3d9b0baecf961ce95ac0031503 Mon Sep 17 00:00:00 2001
From: Mukul Katiyar <mukul at versa-networks.com>
Date: Thu, 7 May 2026 12:59:29 +0000
Subject: [PATCH] net/ice: fix TM hierarchy deletion
[ upstream commit e1f639cba2ce3656ca72c7c4a0648ca9ec61e225 ]
When a TM hierarchy is fully deleted and then committed, the hardware
scheduler nodes may be left with any bandwidth limits that were
programmed by the previous hierarchy commit. These stale limits may
remain in effect the next time the device starts, permanently throttling
traffic even though the TM hierarchy was removed.
Fix this by resetting all descendant hardware scheduler nodes to their
default state when committing an empty hierarchy. Also restore the port
queue count to its hardware default and clear the committed flag so the
port starts cleanly without any TM configuration applied.
Fixes: 715d449a965b ("net/ice: enhance Tx scheduler hierarchy support")
Signed-off-by: Mukul Katiyar <mukul at versa-networks.com>
Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
.mailmap | 1 +
drivers/net/intel/ice/ice_tm.c | 24 ++++++++++++++++++++++--
2 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/.mailmap b/.mailmap
index 50c73e6343..e05056a782 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1132,4 +1132,5 @@ Muhammad Ahmad <muhammad.ahmad at emumba.com>
Muhammad Bilal <m.bilal at emumba.com>
Mukesh Dua <mukesh.dua81 at gmail.com>
+Mukul Katiyar <mukul at versa-networks.com>
Murphy Yang <murphyx.yang at intel.com>
Murthy NSSR <nidadavolu.murthy at caviumnetworks.com>
diff --git a/drivers/net/intel/ice/ice_tm.c b/drivers/net/intel/ice/ice_tm.c
index ff53f2acfd..2bb684bb02 100644
--- a/drivers/net/intel/ice/ice_tm.c
+++ b/drivers/net/intel/ice/ice_tm.c
@@ -806,4 +806,17 @@ create_sched_node_recursive(struct ice_pf *pf, struct ice_port_info *pi,
}
+static void
+reset_hw_node_recursive(struct ice_hw *hw, struct ice_sched_node *node)
+{
+ uint16_t i;
+
+ for (i = 0; i < node->num_children; i++) {
+ reset_hw_node_recursive(hw, node->children[i]);
+ if (ice_cfg_hw_node(hw, NULL, node->children[i]))
+ PMD_DRV_LOG(WARNING, "Failed to reset node %u to default configuration",
+ node->children[i]->info.node_teid);
+ }
+}
+
static int
commit_new_hierarchy(struct rte_eth_dev *dev)
@@ -821,6 +834,13 @@ commit_new_hierarchy(struct rte_eth_dev *dev)
if (sw_root == NULL) {
- PMD_DRV_LOG(ERR, "No root node defined in TM hierarchy");
- return -1;
+ if (!pf->tm_conf.committed) {
+ PMD_DRV_LOG(ERR, "No root node defined in TM hierarchy");
+ return -EINVAL;
+ }
+ /* TM hierarchy deleted. Restore default scheduler state. */
+ reset_hw_node_recursive(hw, hw->vsi_ctx[pf->main_vsi->idx]->sched.vsi_node[0]);
+ pf->main_vsi->nb_qps = pf->lan_nb_qps;
+ pf->tm_conf.committed = false;
+ return ice_alloc_lan_q_ctx(hw, 0, 0, pf->main_vsi->nb_qps);
}
--
2.55.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-23 17:58:00.100015361 +0100
+++ 0050-net-ice-fix-TM-hierarchy-deletion.patch 2026-07-23 17:57:58.662918588 +0100
@@ -1 +1 @@
-From e1f639cba2ce3656ca72c7c4a0648ca9ec61e225 Mon Sep 17 00:00:00 2001
+From 0bcb7d28eafe3f3d9b0baecf961ce95ac0031503 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e1f639cba2ce3656ca72c7c4a0648ca9ec61e225 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -29 +30 @@
-index fb544d0057..1ef52121dd 100644
+index 50c73e6343..e05056a782 100644
@@ -32 +33 @@
-@@ -1138,4 +1138,5 @@ Muhammad Ahmad <muhammad.ahmad at emumba.com>
+@@ -1132,4 +1132,5 @@ Muhammad Ahmad <muhammad.ahmad at emumba.com>
More information about the stable
mailing list