patch 'bus/fslmc: propagate unplug error' has been queued to stable release 25.11.3

Kevin Traynor ktraynor at redhat.com
Tue Jul 28 17:55:59 CEST 2026


Hi,

FYI, your patch has been queued to stable release 25.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/01/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/74577a70bb199d1048ab743afbb562c87ec6a590

Thanks.

Kevin

---
>From 74577a70bb199d1048ab743afbb562c87ec6a590 Mon Sep 17 00:00:00 2001
From: Md Shofiqul Islam <shofiqtest at gmail.com>
Date: Sat, 16 May 2026 14:08:27 +0300
Subject: [PATCH] bus/fslmc: propagate unplug error

[ upstream commit 180b4c70c422580d1dd4b8094366c2186b3a04a9 ]

fslmc_bus_unplug() called drv->remove() and discarded the return value,
unconditionally clearing driver references and reporting success even
when the remove callback signalled failure.  As a result, callers had
no way to detect or react to removal errors.

Capture the return value and propagate it to the caller.  Only clear
the driver references and log successful unplug when the callback
returns zero.

Bugzilla ID: 1914
Fixes: b5721f271cbf ("bus/fslmc: support DPNI hotplug")

Signed-off-by: Md Shofiqul Islam <shofiqtest at gmail.com>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 .mailmap                      | 1 +
 drivers/bus/fslmc/fslmc_bus.c | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 1b3e77431f..0d5a1f3e41 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1058,4 +1058,5 @@ Maxime Leroy <maxime at leroys.fr> <maxime.leroy at 6wind.com>
 Maxime Peim <maxime.peim at gmail.com>
 Md Fahad Iqbal Polash <md.fahad.iqbal.polash at intel.com>
+Md Shofiqul Islam <shofiqtest at gmail.com>
 Megha Ajmera <megha.ajmera at intel.com>
 Meijuan Zhao <meijuanx.zhao at intel.com>
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index d058441a3f..4663b6a6e1 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -641,5 +641,7 @@ fslmc_bus_unplug(struct rte_device *rte_dev)
 
 	if (drv && drv->remove) {
-		drv->remove(dev);
+		int ret = drv->remove(dev);
+		if (ret != 0)
+			return ret;
 		dev->driver = NULL;
 		dev->device.driver = NULL;
-- 
2.55.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-07-28 16:54:51.670084998 +0100
+++ 0029-bus-fslmc-propagate-unplug-error.patch	2026-07-28 16:54:50.769728493 +0100
@@ -1 +1 @@
-From 180b4c70c422580d1dd4b8094366c2186b3a04a9 Mon Sep 17 00:00:00 2001
+From 74577a70bb199d1048ab743afbb562c87ec6a590 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 180b4c70c422580d1dd4b8094366c2186b3a04a9 ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index 6796a30860..4001e5fb0e 100644
+index 1b3e77431f..0d5a1f3e41 100644
@@ -30 +31 @@
-@@ -1066,4 +1066,5 @@ Maxime Leroy <maxime at leroys.fr> <maxime.leroy at 6wind.com>
+@@ -1058,4 +1058,5 @@ Maxime Leroy <maxime at leroys.fr> <maxime.leroy at 6wind.com>
@@ -37 +38 @@
-index 88511d4dc7..c7549a361a 100644
+index d058441a3f..4663b6a6e1 100644
@@ -40 +41 @@
-@@ -538,5 +538,7 @@ fslmc_bus_unplug(struct rte_device *rte_dev)
+@@ -641,5 +641,7 @@ fslmc_bus_unplug(struct rte_device *rte_dev)
@@ -42 +43 @@
- 	if (drv->remove != NULL) {
+ 	if (drv && drv->remove) {
@@ -46,0 +48 @@
+ 		dev->driver = NULL;
@@ -48 +49,0 @@
- 		DPAA2_BUS_INFO("%s Un-Plugged",  dev->device.name);



More information about the stable mailing list