patch 'test/crypto: fix prehash in ML-DSA session' has been queued to stable release 25.11.3
Kevin Traynor
ktraynor at redhat.com
Tue Jul 28 17:56:09 CEST 2026
Hi,
FYI, your patch has been queued to stable release 25.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/01/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/df4e46f87e3269c22e9a63014fe622137f735974
Thanks.
Kevin
---
>From df4e46f87e3269c22e9a63014fe622137f735974 Mon Sep 17 00:00:00 2001
From: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
Date: Wed, 27 May 2026 14:44:00 +0530
Subject: [PATCH] test/crypto: fix prehash in ML-DSA session
[ upstream commit 2a840b97cc1fdebcf89b0b88b6833d8d6c32a6bb ]
Set prehash flag in MLDSA session as per test parameter.
Fixes: 76a5877072c0 ("test/crypto: add ML-KEM and ML-DSA cases")
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
app/test/test_cryptodev_asym.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 22eff90da5..e6c9159301 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -4193,4 +4193,5 @@ mldsa_sign(const void *test_data)
xform.mldsa.type = vector->type;
xform.mldsa.sign_deterministic = vector->sign_deterministic;
+ xform.mldsa.sign_prehash = !!vector->hash;
xform.xform_type = RTE_CRYPTO_ASYM_XFORM_ML_DSA;
@@ -4267,4 +4268,5 @@ mldsa_sign(const void *test_data)
self->op->asym->mldsa.sigver.sign.data = sign;
self->op->asym->mldsa.sigver.sign.length = sign_len;
+ self->op->asym->mldsa.sigver.hash = vector->hash;
TEST_ASSERT_SUCCESS(send_one(),
@@ -4289,4 +4291,5 @@ mldsa_sign(const void *test_data)
self->op->asym->mldsa.sigver.sign.data = sign;
self->op->asym->mldsa.sigver.sign.length = sign_len;
+ self->op->asym->mldsa.sigver.hash = vector->hash;
TEST_ASSERT_SUCCESS(send_one_no_status_check(),
@@ -4309,4 +4312,5 @@ mldsa_verify(const void *test_data)
const uint8_t dev_id = params->valid_devs[0];
struct rte_crypto_asym_xform xform = {0};
+ struct rte_cryptodev_info dev_info;
uint8_t sign[TEST_DATA_SIZE] = {0};
size_t sign_len;
@@ -4314,5 +4318,18 @@ mldsa_verify(const void *test_data)
xform.mldsa.type = vector->type;
xform.mldsa.sign_deterministic = vector->sign_deterministic;
+ xform.mldsa.sign_prehash = !!vector->hash;
xform.xform_type = RTE_CRYPTO_ASYM_XFORM_ML_DSA;
+
+ rte_cryptodev_info_get(dev_id, &dev_info);
+
+ /* Check if prehash is supported */
+ if (vector->hash) {
+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_MLDSA_SIGN_PREHASH)) {
+ RTE_LOG(DEBUG, USER1,
+ "Device doesn't support prehash in ML-DSA verify. Test skipped\n");
+ return TEST_SKIPPED;
+ }
+ }
+
if (rte_cryptodev_asym_session_create(dev_id, &xform,
params->session_mpool, &self->sess) < 0) {
@@ -4336,4 +4353,5 @@ mldsa_verify(const void *test_data)
self->op->asym->mldsa.sigver.sign.data = vector->sign.data;
self->op->asym->mldsa.sigver.sign.length = vector->sign.length;
+ self->op->asym->mldsa.sigver.hash = vector->hash;
TEST_ASSERT_SUCCESS(send_one(),
@@ -4360,4 +4378,5 @@ mldsa_verify(const void *test_data)
self->op->asym->mldsa.sigver.sign.data = sign;
self->op->asym->mldsa.sigver.sign.length = sign_len;
+ self->op->asym->mldsa.sigver.hash = vector->hash;
TEST_ASSERT_SUCCESS(send_one_no_status_check(),
--
2.55.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-07-28 16:54:51.944691016 +0100
+++ 0039-test-crypto-fix-prehash-in-ML-DSA-session.patch 2026-07-28 16:54:50.777862508 +0100
@@ -1 +1 @@
-From 2a840b97cc1fdebcf89b0b88b6833d8d6c32a6bb Mon Sep 17 00:00:00 2001
+From df4e46f87e3269c22e9a63014fe622137f735974 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2a840b97cc1fdebcf89b0b88b6833d8d6c32a6bb ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 73a8198e53..90af49e485 100644
+index 22eff90da5..e6c9159301 100644
@@ -21 +22 @@
-@@ -4237,4 +4237,5 @@ mldsa_sign(const void *test_data)
+@@ -4193,4 +4193,5 @@ mldsa_sign(const void *test_data)
@@ -27 +28 @@
-@@ -4311,4 +4312,5 @@ mldsa_sign(const void *test_data)
+@@ -4267,4 +4268,5 @@ mldsa_sign(const void *test_data)
@@ -33 +34 @@
-@@ -4333,4 +4335,5 @@ mldsa_sign(const void *test_data)
+@@ -4289,4 +4291,5 @@ mldsa_sign(const void *test_data)
@@ -39 +40 @@
-@@ -4353,4 +4356,5 @@ mldsa_verify(const void *test_data)
+@@ -4309,4 +4312,5 @@ mldsa_verify(const void *test_data)
@@ -45 +46 @@
-@@ -4358,5 +4362,18 @@ mldsa_verify(const void *test_data)
+@@ -4314,5 +4318,18 @@ mldsa_verify(const void *test_data)
@@ -64 +65 @@
-@@ -4380,4 +4397,5 @@ mldsa_verify(const void *test_data)
+@@ -4336,4 +4353,5 @@ mldsa_verify(const void *test_data)
@@ -70 +71 @@
-@@ -4404,4 +4422,5 @@ mldsa_verify(const void *test_data)
+@@ -4360,4 +4378,5 @@ mldsa_verify(const void *test_data)
More information about the stable
mailing list