patch 'crypto/ipsec_mb: avoid clearing SNOW3G digest in-place' has been queued to stable release 25.11.3

Kevin Traynor ktraynor at redhat.com
Thu Jul 30 11:17:11 CEST 2026


Hi,

FYI, your patch has been queued to stable release 25.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/04/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/21c039765f5cee01d5333b12aba692ec8bd48845

Thanks.

Kevin

---
>From 21c039765f5cee01d5333b12aba692ec8bd48845 Mon Sep 17 00:00:00 2001
From: Wei Dai <wei.dai at picocom.com>
Date: Tue, 20 Jan 2026 14:12:33 +0800
Subject: [PATCH] crypto/ipsec_mb: avoid clearing SNOW3G digest in-place

[ upstream commit 63195382d57fb0d1505bf1e51c1b92176e1aa4e1 ]

Before this patch, the software crypto_snow3g clear the encrypted auth
snow3g digest when the dst mbuf is same as the src mbuf in crypto op.

This bug can be checked by following way,
start app/dpdk-test --vdev=crypto_snow3g,
run pdcp_autotest
the case failed when i=42 in run_test_for_one_known_vec() in test_pdcp.c.
The case is PDCP control plane auth snow3g gen + cipher snow3g enc.
The case failed because the last 4 bytes are cleared
in last for() loop in line 167
in process_snow3g_cipher_op() in pmd_snow3g.c .

Fixes: 5208d68d30cb ("crypto/ipsec_mb: support snow3g digest appended ops")

Signed-off-by: Wei Dai <wei.dai at picocom.com>
Acked-by: Kai Ji <kai.ji at intel.com>
---
 .mailmap                             | 2 +-
 drivers/crypto/ipsec_mb/pmd_snow3g.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index a1b9409b13..a079cc450a 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1776,5 +1776,5 @@ Wangyu (Eric) <seven.wangyu at huawei.com>
 Waterman Cao <waterman.cao at intel.com>
 Wathsala Vithanage <wathsala.vithanage at arm.com>
-Wei Dai <wei.dai at intel.com>
+Wei Dai <wei.dai at picocom.com> <wei.dai at intel.com>
 Wei Hu <weh at microsoft.com>
 Wei Hu (Xavier) <xavier.huwei at huawei.com>
diff --git a/drivers/crypto/ipsec_mb/pmd_snow3g.c b/drivers/crypto/ipsec_mb/pmd_snow3g.c
index b3c3b05a8a..35fe23c157 100644
--- a/drivers/crypto/ipsec_mb/pmd_snow3g.c
+++ b/drivers/crypto/ipsec_mb/pmd_snow3g.c
@@ -158,5 +158,6 @@ process_snow3g_cipher_op(struct ipsec_mb_qp *qp, struct rte_crypto_op **ops,
 		if ((session->op == IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT ||
 			session->op == IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT) &&
-				ops[i]->sym->m_dst != NULL) {
+				ops[i]->sym->m_dst != NULL &&
+				ops[i]->sym->m_dst != ops[i]->sym->m_src) {
 			digest_appended[i] =
 				snow3g_digest_appended_in_src(ops[i]);
-- 
2.55.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-07-30 10:16:04.072030422 +0100
+++ 0092-crypto-ipsec_mb-avoid-clearing-SNOW3G-digest-in-plac.patch	2026-07-30 10:16:01.512160152 +0100
@@ -1 +1 @@
-From 63195382d57fb0d1505bf1e51c1b92176e1aa4e1 Mon Sep 17 00:00:00 2001
+From 21c039765f5cee01d5333b12aba692ec8bd48845 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 63195382d57fb0d1505bf1e51c1b92176e1aa4e1 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -29 +30 @@
-index eeff1f75bc..9e8ca978a8 100644
+index a1b9409b13..a079cc450a 100644
@@ -32 +33 @@
-@@ -1801,5 +1801,5 @@ Wangyu (Eric) <seven.wangyu at huawei.com>
+@@ -1776,5 +1776,5 @@ Wangyu (Eric) <seven.wangyu at huawei.com>



More information about the stable mailing list