patch 'net/pcap: fix Windows build' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Jun 11 15:19:24 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/13/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/cbbec08e5c9ce2fd7d2ec0a232dc13656bc1878e
Thanks.
Luca Boccassi
---
>From cbbec08e5c9ce2fd7d2ec0a232dc13656bc1878e Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Sun, 19 Apr 2026 09:09:35 -0700
Subject: [PATCH] net/pcap: fix Windows build
[ upstream commit 638fdda73fcee4a0970f44e510027f20c92cd632 ]
The log messages in the pcap OS dependent code for Windows
was never converted during the last release.
It looks like the osdep part of pcap was not being built.
Building requires have libpcap for Windows built which is not
part of the CI infrastructure.
Fixes: 2b843cac232e ("drivers: use per line logging in helpers")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
Acked-by: David Marchand <david.marchand at redhat.com>
---
drivers/net/pcap/pcap_osdep_windows.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/pcap/pcap_osdep_windows.c b/drivers/net/pcap/pcap_osdep_windows.c
index 1d398dc7ed..0965c2f5c9 100644
--- a/drivers/net/pcap/pcap_osdep_windows.c
+++ b/drivers/net/pcap/pcap_osdep_windows.c
@@ -53,7 +53,7 @@ osdep_iface_index_get(const char *device_name)
ret = GetAdapterIndex(adapter_name, &index);
if (ret != NO_ERROR) {
- PMD_LOG(ERR, "GetAdapterIndex(%S) = %lu\n", adapter_name, ret);
+ PMD_LOG(ERR, "GetAdapterIndex(%S) = %lu", adapter_name, ret);
return -1;
}
@@ -75,20 +75,20 @@ osdep_iface_mac_get(const char *device_name, struct rte_ether_addr *mac)
sys_ret = GetAdaptersAddresses(AF_UNSPEC, 0, NULL, NULL, &size);
if (sys_ret != ERROR_BUFFER_OVERFLOW) {
- PMD_LOG(ERR, "GetAdapterAddresses() = %lu, expected %lu\n",
+ PMD_LOG(ERR, "GetAdapterAddresses() = %lu, expected %lu",
sys_ret, ERROR_BUFFER_OVERFLOW);
return -1;
}
info = (IP_ADAPTER_ADDRESSES *)malloc(size);
if (info == NULL) {
- PMD_LOG(ERR, "Cannot allocate adapter address info\n");
+ PMD_LOG(ERR, "Cannot allocate adapter address info");
return -1;
}
sys_ret = GetAdaptersAddresses(AF_UNSPEC, 0, NULL, info, &size);
if (sys_ret != ERROR_SUCCESS) {
- PMD_LOG(ERR, "GetAdapterAddresses() = %lu\n", sys_ret);
+ PMD_LOG(ERR, "GetAdapterAddresses() = %lu", sys_ret);
free(info);
return -1;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-06-11 14:20:01.970912379 +0100
+++ 0015-net-pcap-fix-Windows-build.patch 2026-06-11 14:20:01.182745205 +0100
@@ -1 +1 @@
-From 638fdda73fcee4a0970f44e510027f20c92cd632 Mon Sep 17 00:00:00 2001
+From cbbec08e5c9ce2fd7d2ec0a232dc13656bc1878e Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 638fdda73fcee4a0970f44e510027f20c92cd632 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list