patch 'net/iavf: fix disabling of promiscuous modes on close' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Jun 11 15:19:46 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/13/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/897c4654f4e779398e419243e39778ad79e90cc6
Thanks.
Luca Boccassi
---
>From 897c4654f4e779398e419243e39778ad79e90cc6 Mon Sep 17 00:00:00 2001
From: Ciara Loftus <ciara.loftus at intel.com>
Date: Tue, 31 Mar 2026 13:01:17 +0000
Subject: [PATCH] net/iavf: fix disabling of promiscuous modes on close
[ upstream commit 1428895ad4174678480bdaec1f96d055e9d78fe2 ]
Commit 41515403f184 ("net/iavf: disable promiscuous mode on close")
introduced logic that disabled promiscuous mode when closing the device.
However this logic was effectively disabled by commit 676d986b4b86
("net/iavf: fix crash after VF reset failure") which prevented the
configuration of promiscuous mode when the adapter was marked as
"closed". Re-enable the disabling logic by moving it to earlier in the
device close function, before the adapter is marked as "closed".
Fixes: 676d986b4b86 ("net/iavf: fix crash after VF reset failure")
Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 18551f3120..926540f18e 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -2973,6 +2973,12 @@ iavf_dev_close(struct rte_eth_dev *dev)
vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT;
}
+ /* Disable promiscuous mode before resetting the VF. This is to avoid
+ * potential issues when the PF is bound to the kernel driver.
+ */
+ if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)
+ iavf_config_promisc(adapter, false, false);
+
adapter->closed = true;
/* free iAVF security device context all related resources */
@@ -2981,14 +2987,6 @@ iavf_dev_close(struct rte_eth_dev *dev)
iavf_flow_flush(dev, NULL);
iavf_flow_uninit(adapter);
- /*
- * disable promiscuous mode before reset vf
- * it is a workaround solution when work with kernel driver
- * and it is not the normal way
- */
- if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)
- iavf_config_promisc(adapter, false, false);
-
iavf_vf_reset(hw);
iavf_shutdown_adminq(hw);
if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) {
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-06-11 14:20:02.794324036 +0100
+++ 0037-net-iavf-fix-disabling-of-promiscuous-modes-on-close.patch 2026-06-11 14:20:01.210745885 +0100
@@ -1 +1 @@
-From 1428895ad4174678480bdaec1f96d055e9d78fe2 Mon Sep 17 00:00:00 2001
+From 897c4654f4e779398e419243e39778ad79e90cc6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1428895ad4174678480bdaec1f96d055e9d78fe2 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
- drivers/net/intel/iavf/iavf_ethdev.c | 14 ++++++--------
+ drivers/net/iavf/iavf_ethdev.c | 14 ++++++--------
@@ -23,5 +24,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
-index 6d0306b3ac..8dae992239 100644
---- a/drivers/net/intel/iavf/iavf_ethdev.c
-+++ b/drivers/net/intel/iavf/iavf_ethdev.c
-@@ -2947,6 +2947,12 @@ iavf_dev_close(struct rte_eth_dev *dev)
+diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
+index 18551f3120..926540f18e 100644
+--- a/drivers/net/iavf/iavf_ethdev.c
++++ b/drivers/net/iavf/iavf_ethdev.c
+@@ -2973,6 +2973,12 @@ iavf_dev_close(struct rte_eth_dev *dev)
@@ -40 +41 @@
-@@ -2958,14 +2964,6 @@ iavf_dev_close(struct rte_eth_dev *dev)
+@@ -2981,14 +2987,6 @@ iavf_dev_close(struct rte_eth_dev *dev)
@@ -53 +53,0 @@
- vf->aq_intr_enabled = false;
@@ -54,0 +55 @@
+ if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) {
More information about the stable
mailing list