patch 'net/iavf: remove dead code in TM node parameter check' has been queued to stable release 24.11.7
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Jun 11 15:19:48 CEST 2026
Hi,
FYI, your patch has been queued to stable release 24.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/13/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/9dcb46ebaf5cb04ee53e4868d2130b28edaac90d
Thanks.
Luca Boccassi
---
>From 9dcb46ebaf5cb04ee53e4868d2130b28edaac90d Mon Sep 17 00:00:00 2001
From: Sergei Iashin <yashin.sergey at gmail.com>
Date: Tue, 7 Apr 2026 14:47:30 +0300
Subject: [PATCH] net/iavf: remove dead code in TM node parameter check
[ upstream commit 5acdd683a5638bdb56c203377b4f3bdef11bf78e ]
The non-leaf validation in iavf_node_param_check() unconditionally
rejects a non-NULL wfq_weight_mode pointer at the top of the block.
The else-if clause below re-tests the same pointer, which is guaranteed
NULL at that point, making the branch unreachable dead code.
Remove the dead else-if block. No functional change.
Fixes: 44d0a720a538 ("net/iavf: query QoS capabilities and set queue TC mapping")
Signed-off-by: Sergei Iashin <yashin.sergey at gmail.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
drivers/net/iavf/iavf_tm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/iavf/iavf_tm.c b/drivers/net/iavf/iavf_tm.c
index 1d12196ba6..efdbb45b62 100644
--- a/drivers/net/iavf/iavf_tm.c
+++ b/drivers/net/iavf/iavf_tm.c
@@ -178,12 +178,6 @@ iavf_node_param_check(struct iavf_info *vf, uint32_t node_id,
RTE_TM_ERROR_TYPE_NODE_PARAMS_N_SP_PRIORITIES;
error->message = "SP priority not supported";
return -EINVAL;
- } else if (params->nonleaf.wfq_weight_mode &&
- !(*params->nonleaf.wfq_weight_mode)) {
- error->type =
- RTE_TM_ERROR_TYPE_NODE_PARAMS_WFQ_WEIGHT_MODE;
- error->message = "WFP should be byte mode";
- return -EINVAL;
}
return 0;
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-06-11 14:20:02.869474983 +0100
+++ 0039-net-iavf-remove-dead-code-in-TM-node-parameter-check.patch 2026-06-11 14:20:01.210745885 +0100
@@ -1 +1 @@
-From 5acdd683a5638bdb56c203377b4f3bdef11bf78e Mon Sep 17 00:00:00 2001
+From 9dcb46ebaf5cb04ee53e4868d2130b28edaac90d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5acdd683a5638bdb56c203377b4f3bdef11bf78e ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
- drivers/net/intel/iavf/iavf_tm.c | 6 ------
+ drivers/net/iavf/iavf_tm.c | 6 ------
@@ -22 +23 @@
-diff --git a/drivers/net/intel/iavf/iavf_tm.c b/drivers/net/intel/iavf/iavf_tm.c
+diff --git a/drivers/net/iavf/iavf_tm.c b/drivers/net/iavf/iavf_tm.c
@@ -24,2 +25,2 @@
---- a/drivers/net/intel/iavf/iavf_tm.c
-+++ b/drivers/net/intel/iavf/iavf_tm.c
+--- a/drivers/net/iavf/iavf_tm.c
++++ b/drivers/net/iavf/iavf_tm.c
More information about the stable
mailing list