[PATCH v2] bus/fslmc: convert queue storage macros to inline functions

David Marchand david.marchand at redhat.com
Mon Jun 29 12:41:48 CEST 2026


Hello,

Thanks for working on this issue.

On Sun, 28 Jun 2026 at 17:27, Weijun Pan <wpan3636 at gmail.com> wrote:
>
> From: Weijun Pan <wpan36 at wisc.edu>
>
> The queue storage allocation and free helpers are implemented as macros
> which declare local variables in the caller scope. This can cause shadow
> warnings when -Wshadow is enabled.
>
> Convert them to static inline functions to avoid macro-local variable
> scope issues without changing behavior.
>
> Bugzilla ID: 1744

This bugzilla is about compiling with -Wshadow.

The proposed fix is partial.
As I reported in my previous mail, enabling -Wshadow after the current
patch still shows many build warnings in
drivers/bus/fslmc/qbman/qbman_portal.c.
https://inbox.dpdk.org/dev/CAJFAV8w-VQJb6jM0KgAVP1rJKyUUwiBA6_seOCDwMX47rZmYyA@mail.gmail.com/

Could you work on a complete fix so the bz can be closed?


> Fixes: 12d98eceb8ac ("bus/fslmc: enhance QBMAN DQ storage logic")
> Cc: jun.yang at nxp.com
> Cc: stable at dpdk.org

Afaics, nothing is broken in the current code, why do we *need* to
backport the change?


> Signed-off-by: Weijun Pan <wpan36 at wisc.edu>


-- 
David Marchand



More information about the stable mailing list