patch 'net/bnxt/tf_ulp: check EM key pad result' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Nov 5 17:41:55 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/6c4b4afa7385e6a29411e1919ce713237a97662d

Thanks.

Luca Boccassi

---
>From 6c4b4afa7385e6a29411e1919ce713237a97662d Mon Sep 17 00:00:00 2001
From: Manish Kurup <manish.kurup at broadcom.com>
Date: Tue, 20 Oct 2026 01:59:51 -0500
Subject: [PATCH] net/bnxt/tf_ulp: check EM key pad result

[ upstream commit 5bf5fa0bfd7add22133369fb864d747b7301f712 ]

ulp_mapper_tfc_em_tbl_process() pads the EM key to a record boundary
with ulp_blob_pad_push() but ignores its return value. The function
returns -1 and leaves the write index unchanged when the requested
pad does not fit in the blob, so with a long dynamic key the key was
used without its padding. The key length computed afterwards, and the
position at which the result is appended, are then wrong, and a
malformed EM entry is sent to the hardware.

Check the return value and fail the flow with -EINVAL, as the other
ulp_blob_pad_push() callers in the mapper already do.

Fixes: dd0191d5e70d ("net/bnxt/tf_ulp: support Thor2 ULP layer")

Signed-off-by: Manish Kurup <manish.kurup at broadcom.com>
---
 drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c b/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
index 11be185551f..bc207661ea5 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
@@ -523,7 +523,10 @@ ulp_mapper_tfc_em_tbl_process(struct bnxt_ulp_mapper_parms *parms,
 		align_len_bits = dparms->em_blk_align_bits - key_len;
 	}
 
-	ulp_blob_pad_push(&key, align_len_bits);
+	if (unlikely(ulp_blob_pad_push(&key, align_len_bits) < 0)) {
+		BNXT_DRV_DBG(ERR, "Failed to pad EM key\n");
+		return -EINVAL;
+	}
 	key_len = ULP_BITS_2_BYTE(ulp_blob_data_len_get(&key));
 	ulp_blob_perform_byte_reverse(&key, key_len);
 #ifdef RTE_LIBRTE_BNXT_TRUFLOW_DEBUG
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-11-05 16:42:46.096720784 +0000
+++ 0028-net-bnxt-tf_ulp-check-EM-key-pad-result.patch	2026-11-05 16:42:44.921060786 +0000
@@ -1 +1 @@
-From 5bf5fa0bfd7add22133369fb864d747b7301f712 Mon Sep 17 00:00:00 2001
+From 6c4b4afa7385e6a29411e1919ce713237a97662d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5bf5fa0bfd7add22133369fb864d747b7301f712 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index 2cba6fffa8..7ace08838f 100644
+index 11be185551f..bc207661ea5 100644
@@ -29 +30 @@
-@@ -519,7 +519,10 @@ ulp_mapper_tfc_em_tbl_process(struct bnxt_ulp_mapper_parms *parms,
+@@ -523,7 +523,10 @@ ulp_mapper_tfc_em_tbl_process(struct bnxt_ulp_mapper_parms *parms,
@@ -40 +41 @@
- 	/* Create the result data blob */
+ #ifdef RTE_LIBRTE_BNXT_TRUFLOW_DEBUG


More information about the stable mailing list