patch 'net/bnxt: fix aliasing in firmware command writes' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 5 17:41:58 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/df99bcd66292b36e77040a7194511e3913e03411
Thanks.
Luca Boccassi
---
>From df99bcd66292b36e77040a7194511e3913e03411 Mon Sep 17 00:00:00 2001
From: Alexander Goodkind <alex at goodkind.io>
Date: Sat, 17 Oct 2026 19:29:29 -0700
Subject: [PATCH] net/bnxt: fix aliasing in firmware command writes
[ upstream commit e844796b086c0c2cf257f87cd669b10212b09430 ]
Use memcpy to copy each firmware command word into a local uint32_t
before writing it to the card. Replace the uint32_t pointer reads in
bnxt_hwrm_send_message() with byte access.
Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
Signed-off-by: Alexander Goodkind <alex at goodkind.io>
---
.mailmap | 1 +
drivers/net/bnxt/bnxt_hwrm.c | 11 +++++++----
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/.mailmap b/.mailmap
index 33b0aa12482..99d1a7c2a59 100644
--- a/.mailmap
+++ b/.mailmap
@@ -56,6 +56,7 @@ Alex Chapman <alex.chapman at arm.com>
Alexander Bechikov <asb.tyum at gmail.com>
Alexander Belyakov <abelyako at gmail.com>
Alexander Chernavin <achernavin at netgate.com>
+Alexander Goodkind <alex at goodkind.io>
Alexander Guy <alexander at andern.org>
Alexander Kozyrev <akozyrev at nvidia.com> <akozyrev at mellanox.com>
Alexander Matushevsky <matua at amazon.com>
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 6519f7fad8e..fe5ff03267d 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -483,7 +483,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,
unsigned int i;
struct input *req = msg;
struct output *resp = bp->hwrm_cmd_resp_addr;
- uint32_t *data = msg;
+ const uint8_t *data = msg;
uint8_t *bar;
uint8_t *valid;
uint16_t max_req_len = bp->max_req_len;
@@ -526,7 +526,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,
short_input.req_addr =
rte_cpu_to_le_64(bp->hwrm_short_cmd_req_dma_addr);
- data = (uint32_t *)&short_input;
+ data = (const uint8_t *)&short_input;
msg_len = sizeof(short_input);
max_req_len = BNXT_HWRM_SHORT_REQ_LEN;
@@ -534,9 +534,12 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg,
/* Write request msg to hwrm channel */
for (i = 0; i < msg_len; i += 4) {
+ uint32_t request_word;
+
bar = (uint8_t *)bp->bar0 + bar_offset + i;
- rte_write32(*data, bar);
- data++;
+ memcpy(&request_word, data, sizeof(request_word));
+ rte_write32(request_word, bar);
+ data += sizeof(request_word);
}
/* Zero the rest of the request space */
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-11-05 16:42:46.213363532 +0000
+++ 0031-net-bnxt-fix-aliasing-in-firmware-command-writes.patch 2026-11-05 16:42:44.929061025 +0000
@@ -1 +1 @@
-From e844796b086c0c2cf257f87cd669b10212b09430 Mon Sep 17 00:00:00 2001
+From df99bcd66292b36e77040a7194511e3913e03411 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e844796b086c0c2cf257f87cd669b10212b09430 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index d23dac66db..08317e81e6 100644
+index 33b0aa12482..99d1a7c2a59 100644
@@ -23 +24 @@
-@@ -65,6 +65,7 @@ Alex Zelezniak <alexz at att.com>
+@@ -56,6 +56,7 @@ Alex Chapman <alex.chapman at arm.com>
@@ -32 +33 @@
-index ab1521953a..573a33b2de 100644
+index 6519f7fad8e..fe5ff03267d 100644
More information about the stable
mailing list