patch 'net/ixgbe: fix ntuple filter priority' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 5 17:42:07 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/dd9802a1fbc2fe8a005e90d5e1965042452f45e3
Thanks.
Luca Boccassi
---
>From dd9802a1fbc2fe8a005e90d5e1965042452f45e3 Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov at intel.com>
Date: Tue, 13 Oct 2026 13:03:09 +0100
Subject: [PATCH] net/ixgbe: fix ntuple filter priority
[ upstream commit c5849b075ad7db862a68ce48a5fe85d70fe8f659 ]
Currently, handling of ntuple filter priority is incorrect: it directly
translates values inside the valid range (001b-111b), and clamps all
invalid to 1. This leads to equivalence between rte_flow highest
priority value (0), and rte_flow lower priority values (8+), both of
which are mapped to 1 (lowest priority), while the 1-7 range is reversed
(in ntuple, 111b is highest priority, but in rte_flow it is the lowest).
Fix the calculation by
- Translating highest rte_flow priority to highest ntuple priority
- Only clamping low priority values to 1 (lowest priority)
- Reversing the 1-7 mapping to preserve semantic meaning
Fixes: 672be56d76a2 ("net/ixgbe: parse n-tuple filter")
Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index de3f0d17111..f8dfb432f44 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -190,6 +190,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
const struct rte_flow_item_vlan *vlan_mask;
struct rte_flow_item_eth eth_null;
struct rte_flow_item_vlan vlan_null;
+ uint16_t priority;
if (!pattern) {
rte_flow_error_set(error,
@@ -605,10 +606,22 @@ action:
attr, "Error priority.");
return -rte_errno;
}
- filter->priority = (uint16_t)attr->priority;
- if (attr->priority < IXGBE_MIN_N_TUPLE_PRIO ||
- attr->priority > IXGBE_MAX_N_TUPLE_PRIO)
- filter->priority = 1;
+
+ /*
+ * rte_flow priority: 0 through UINT32_MAX, 0 is highest
+ *
+ * ntuple priority: 001b through 111b, 111b is highest
+ *
+ * which means we need to transform priority from rte_flow to ntuple:
+ *
+ * 1) clamp max value
+ * 2) reverse
+ * 3) add min value
+ */
+ priority = RTE_MIN(IXGBE_MAX_N_TUPLE_PRIO - 1, (uint16_t)attr->priority);
+ priority = IXGBE_MAX_N_TUPLE_PRIO - 1 - priority;
+ priority += IXGBE_MIN_N_TUPLE_PRIO;
+ filter->priority = priority;
return 0;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-11-05 16:42:46.554709990 +0000
+++ 0040-net-ixgbe-fix-ntuple-filter-priority.patch 2026-11-05 16:42:44.949061623 +0000
@@ -1 +1 @@
-From c5849b075ad7db862a68ce48a5fe85d70fe8f659 Mon Sep 17 00:00:00 2001
+From dd9802a1fbc2fe8a005e90d5e1965042452f45e3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c5849b075ad7db862a68ce48a5fe85d70fe8f659 ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org
@@ -25,2 +26,2 @@
- drivers/net/intel/ixgbe/ixgbe_flow.c | 19 ++++++++++++++++---
- 1 file changed, 16 insertions(+), 3 deletions(-)
+ drivers/net/ixgbe/ixgbe_flow.c | 21 +++++++++++++++++----
+ 1 file changed, 17 insertions(+), 4 deletions(-)
@@ -28,5 +29,5 @@
-diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c
-index 76eec33839..547c6621d3 100644
---- a/drivers/net/intel/ixgbe/ixgbe_flow.c
-+++ b/drivers/net/intel/ixgbe/ixgbe_flow.c
-@@ -209,6 +209,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
+diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
+index de3f0d17111..f8dfb432f44 100644
+--- a/drivers/net/ixgbe/ixgbe_flow.c
++++ b/drivers/net/ixgbe/ixgbe_flow.c
+@@ -190,6 +190,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
@@ -38,6 +39,6 @@
- /* Priority must be 16-bit */
- if (attr->priority > UINT16_MAX) {
-@@ -503,9 +504,21 @@ action:
-
- filter->queue = q_act->index;
-
+ if (!pattern) {
+ rte_flow_error_set(error,
+@@ -605,10 +606,22 @@ action:
+ attr, "Error priority.");
+ return -rte_errno;
+ }
@@ -45,2 +46,4 @@
-- if (attr->priority < IXGBE_MIN_N_TUPLE_PRIO || attr->priority > IXGBE_MAX_N_TUPLE_PRIO)
-- filter->priority = 1;
+- if (attr->priority < IXGBE_MIN_N_TUPLE_PRIO ||
+- attr->priority > IXGBE_MAX_N_TUPLE_PRIO)
+- filter->priority = 1;
++
More information about the stable
mailing list