patch 'net/netvsc: fix link status not updated on host indication' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 5 17:42:29 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/fb010b89389f5df00dc691faedf646b692ed1781
Thanks.
Luca Boccassi
---
>From fb010b89389f5df00dc691faedf646b692ed1781 Mon Sep 17 00:00:00 2001
From: Shrey Khandelwal <s.khandelwal at f5.com>
Date: Tue, 13 Oct 2026 19:07:44 -0700
Subject: [PATCH] net/netvsc: fix link status not updated on host indication
[ upstream commit 2d3c00b543f487e577f89defea1dc5ce2b5866e9 ]
With LSC enabled and the port started, rte_eth_link_get() returns
the cached link. When the host reports a link change, the alarm only
calls the LSC callback and nothing updates the cached link, so the
application keeps seeing the old link status and speed.
The indication already has the new state: media connect or disconnect
for the status, and the new speed in the status buffer. Save it when
the indication is received, and apply it to the cached link in the
alarm before calling the LSC callback. The callback is only called if
the link changed. If several indications arrive before the alarm
runs, the latest state is used. Indications received while the port
is stopped are dropped, as the link is queried when the port starts.
Querying the host from the alarm instead could block the interrupt
thread for up to 60 seconds, and fails with -EBUSY while another
RNDIS request is pending.
Check the message length before reading it, and the status buffer
offset and length before reading the speed.
Fixes: 501a7e573564 ("net/netvsc: process link change messages in alarm")
Signed-off-by: Shrey Khandelwal <s.khandelwal at f5.com>
---
drivers/net/netvsc/hn_rndis.c | 90 +++++++++++++++++++++++++++++++++--
drivers/net/netvsc/hn_rndis.h | 3 +-
drivers/net/netvsc/hn_rxtx.c | 2 +-
drivers/net/netvsc/hn_var.h | 4 ++
4 files changed, 93 insertions(+), 6 deletions(-)
diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c
index 24723ff8425..c0d9afdb091 100644
--- a/drivers/net/netvsc/hn_rndis.c
+++ b/drivers/net/netvsc/hn_rndis.c
@@ -292,12 +292,76 @@ static int hn_nvs_send_rndis_ctrl(struct vmbus_channel *chan,
*/
static void hn_rndis_link_alarm(void *arg)
{
- rte_eth_dev_callback_process(arg, RTE_ETH_EVENT_INTR_LSC, NULL);
+ struct rte_eth_dev *dev = arg;
+ struct hn_data *hv = dev->data->dev_private;
+ struct rte_eth_link link, old;
+ uint32_t status, speed;
+
+ status = rte_atomic_exchange_explicit(&hv->link_ind_status, 0,
+ rte_memory_order_relaxed);
+ speed = rte_atomic_exchange_explicit(&hv->link_ind_speed, 0,
+ rte_memory_order_relaxed);
+
+ /* If stopped, the link is queried when the port starts. */
+ if ((status == 0 && speed == 0) || !dev->data->dev_started)
+ return;
+
+ rte_eth_linkstatus_get(dev, &old);
+ link = old;
+ if (status == RNDIS_STATUS_MEDIA_CONNECT)
+ link.link_status = RTE_ETH_LINK_UP;
+ else if (status == RNDIS_STATUS_MEDIA_DISCONNECT)
+ link.link_status = RTE_ETH_LINK_DOWN;
+ if (speed != 0)
+ link.link_speed = speed / 10000;
+ if (link.link_status == old.link_status &&
+ link.link_speed == old.link_speed)
+ return;
+
+ rte_eth_linkstatus_set(dev, &link);
+ rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
+}
+
+static void
+hn_rndis_link_alarm_set(struct rte_eth_dev *dev)
+{
+ if (rte_eal_alarm_set(10, hn_rndis_link_alarm, dev) != 0)
+ PMD_DRV_LOG(ERR, "port %u: cannot schedule link update",
+ dev->data->port_id);
+}
+
+/*
+ * Get the link speed, in 100 bps units, from the status buffer.
+ * Use the received length, as older hosts do not count the status
+ * buffer in the message length.
+ */
+static int
+hn_rndis_link_speed_get(const struct rndis_status_msg *indicate,
+ uint32_t len, uint32_t *speed)
+{
+ uint32_t ofs;
+
+ ofs = RNDIS_STBUFOFFSET_ABS(indicate->stbufoffset);
+ if (indicate->stbuflen < sizeof(*speed) ||
+ ofs < sizeof(*indicate) || ofs > len ||
+ len - ofs < indicate->stbuflen)
+ return -EINVAL;
+
+ memcpy(speed, (const uint8_t *)indicate + ofs, sizeof(*speed));
+ return 0;
}
-void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg)
+void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg,
+ uint32_t len)
{
const struct rndis_status_msg *indicate = msg;
+ struct hn_data *hv = dev->data->dev_private;
+ uint32_t speed;
+
+ if (len < sizeof(*indicate)) {
+ PMD_DRV_LOG(ERR, "truncated RNDIS status message: len %u", len);
+ return;
+ }
hn_rndis_dump(msg);
@@ -310,10 +374,28 @@ void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg)
break;
case RNDIS_STATUS_LINK_SPEED_CHANGE:
+ if (!dev->data->dev_conf.intr_conf.lsc)
+ break;
+ if (hn_rndis_link_speed_get(indicate, len, &speed) != 0) {
+ PMD_DRV_LOG(ERR,
+ "invalid link speed indication: len %u buf %u:%u",
+ len, indicate->stbufoffset,
+ indicate->stbuflen);
+ break;
+ }
+ rte_atomic_store_explicit(&hv->link_ind_speed, speed,
+ rte_memory_order_relaxed);
+ hn_rndis_link_alarm_set(dev);
+ break;
+
case RNDIS_STATUS_MEDIA_CONNECT:
case RNDIS_STATUS_MEDIA_DISCONNECT:
- if (dev->data->dev_conf.intr_conf.lsc)
- rte_eal_alarm_set(10, hn_rndis_link_alarm, dev);
+ if (!dev->data->dev_conf.intr_conf.lsc)
+ break;
+ rte_atomic_store_explicit(&hv->link_ind_status,
+ indicate->status,
+ rte_memory_order_relaxed);
+ hn_rndis_link_alarm_set(dev);
break;
default:
PMD_DRV_LOG(NOTICE, "unknown RNDIS indication: %#x",
diff --git a/drivers/net/netvsc/hn_rndis.h b/drivers/net/netvsc/hn_rndis.h
index 7f40f6221de..524b8f221ff 100644
--- a/drivers/net/netvsc/hn_rndis.h
+++ b/drivers/net/netvsc/hn_rndis.h
@@ -6,7 +6,8 @@ struct hn_data;
void hn_rndis_receive_response(struct hn_data *hv,
const void *data, uint32_t len);
-void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg);
+void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg,
+ uint32_t len);
int hn_rndis_attach(struct hn_data *hv);
void hn_rndis_detach(struct hn_data *hv);
int hn_rndis_get_eaddr(struct hn_data *hv, uint8_t *eaddr);
diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 01a02cb9ec7..87d107bb5ee 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -771,7 +771,7 @@ hn_rndis_receive(struct rte_eth_dev *dev, struct hn_rx_queue *rxq,
break;
case RNDIS_INDICATE_STATUS_MSG:
- hn_rndis_link_status(dev, buf);
+ hn_rndis_link_status(dev, buf, len);
break;
case RNDIS_INITIALIZE_CMPLT:
diff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h
index 65a9fca4364..591a045cb8a 100644
--- a/drivers/net/netvsc/hn_var.h
+++ b/drivers/net/netvsc/hn_var.h
@@ -144,6 +144,10 @@ struct hn_data {
uint32_t link_status;
uint32_t link_speed;
+ /* Pending host link indication, applied by the link alarm */
+ RTE_ATOMIC(uint32_t) link_ind_status; /* RNDIS_STATUS_MEDIA_* or 0 */
+ RTE_ATOMIC(uint32_t) link_ind_speed; /* in 100 bps, or 0 */
+
struct rte_mem_resource rxbuf_res; /* UIO resource for Rx */
uint32_t rxbuf_section_cnt; /* # of Rx sections */
uint32_t rx_copybreak;
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-11-05 16:42:47.359717708 +0000
+++ 0062-net-netvsc-fix-link-status-not-updated-on-host-indic.patch 2026-11-05 16:42:44.993062938 +0000
@@ -1 +1 @@
-From 2d3c00b543f487e577f89defea1dc5ce2b5866e9 Mon Sep 17 00:00:00 2001
+From fb010b89389f5df00dc691faedf646b692ed1781 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2d3c00b543f487e577f89defea1dc5ce2b5866e9 ]
+
@@ -27 +28,0 @@
-Cc: stable at dpdk.org
@@ -38 +39 @@
-index 4e13d7c38f4..5a965564b28 100644
+index 24723ff8425..c0d9afdb091 100644
@@ -41 +42 @@
-@@ -294,12 +294,76 @@ static int hn_nvs_send_rndis_ctrl(struct hn_data *hv,
+@@ -292,12 +292,76 @@ static int hn_nvs_send_rndis_ctrl(struct vmbus_channel *chan,
@@ -120 +121 @@
-@@ -312,10 +376,28 @@ void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg)
+@@ -310,10 +374,28 @@ void hn_rndis_link_status(struct rte_eth_dev *dev, const void *msg)
@@ -166 +167 @@
-index 6f536610f23..9a04861005b 100644
+index 01a02cb9ec7..87d107bb5ee 100644
@@ -169 +170 @@
-@@ -774,7 +774,7 @@ hn_rndis_receive(struct rte_eth_dev *dev, struct hn_rx_queue *rxq,
+@@ -771,7 +771,7 @@ hn_rndis_receive(struct rte_eth_dev *dev, struct hn_rx_queue *rxq,
@@ -179 +180 @@
-index d7124a7df90..7d9a9508161 100644
+index 65a9fca4364..591a045cb8a 100644
More information about the stable
mailing list