patch 'net/txgbe: fix Rx packet buffer size with flow director' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Nov 5 17:43:03 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/17f9ada39e337217c06ed53140778d56e6fc4247
Thanks.
Luca Boccassi
---
>From 17f9ada39e337217c06ed53140778d56e6fc4247 Mon Sep 17 00:00:00 2001
From: Zhang Tengfei <zhtfdev at gmail.com>
Date: Thu, 15 Oct 2026 00:39:22 +0800
Subject: [PATCH] net/txgbe: fix Rx packet buffer size with flow director
[ upstream commit 0db1d71a1e532aba82454ed8f985bc8f9ca9aa68 ]
Enabling Flow Director reduces PBRXSIZE(0) to reserve packet buffer
memory for the filter table. The new size was computed from the
current register value, but the FDIR mode is reset to none when the
last rule is destroyed, on flush, or when enabling FDIR fails, without
restoring the buffer. The next FDIR rule created or validated then
enabled FDIR again and reduced the buffer a second time, until the
size underflowed.
Compute PBRXSIZE(0) from the default packet buffer size instead.
Fixes: ea230dda16ad ("net/txgbe: configure flow director filter")
Signed-off-by: Zhang Tengfei <zhtfdev at gmail.com>
---
drivers/net/txgbe/txgbe_fdir.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_fdir.c b/drivers/net/txgbe/txgbe_fdir.c
index 6b83a7379d1..d77815af7c8 100644
--- a/drivers/net/txgbe/txgbe_fdir.c
+++ b/drivers/net/txgbe/txgbe_fdir.c
@@ -390,11 +390,10 @@ txgbe_fdir_configure(struct rte_eth_dev *dev)
/*
* Before enabling Flow Director, the Rx Packet Buffer size
- * must be reduced. The new value is the current size minus
+ * must be reduced. The new value is the default size minus
* flow director memory usage size.
*/
- pbsize = rd32(hw, TXGBE_PBRXSIZE(0));
- pbsize -= TXGBD_FDIRCTL_BUF_BYTE(fdirctrl);
+ pbsize = (hw->mac.rx_pb_size << 10) - TXGBD_FDIRCTL_BUF_BYTE(fdirctrl);
wr32(hw, TXGBE_PBRXSIZE(0), pbsize);
/*
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-11-05 16:42:48.593091832 +0000
+++ 0096-net-txgbe-fix-Rx-packet-buffer-size-with-flow-direct.patch 2026-11-05 16:42:45.033064133 +0000
@@ -1 +1 @@
-From 0db1d71a1e532aba82454ed8f985bc8f9ca9aa68 Mon Sep 17 00:00:00 2001
+From 17f9ada39e337217c06ed53140778d56e6fc4247 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0db1d71a1e532aba82454ed8f985bc8f9ca9aa68 ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 67f586ffc7..cee38a42b8 100644
+index 6b83a7379d1..d77815af7c8 100644
More information about the stable
mailing list