patch 'net/enic: check notify set return value during init' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:48:23 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/b74997b5202d871f13289df4b6037de2cddcea1d
Thanks.
Luca Boccassi
---
>From b74997b5202d871f13289df4b6037de2cddcea1d Mon Sep 17 00:00:00 2001
From: Alexey Simakov <bigalex934 at gmail.com>
Date: Mon, 20 Jul 2026 12:33:39 +0300
Subject: [PATCH] net/enic: check notify set return value during init
[ upstream commit 7b3647137055811a0f6d3fe43da517cf9ba11c9b ]
The return value of vnic_dev_notify_set() is silently ignored in
enic_dev_init(), so a memory allocation failure or hardware command
error goes unnoticed and the driver continues with uninitialized
notification state.
Check the return value and propagate the error to abort probe when
notification setup fails.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: Alexey Simakov <bigalex934 at gmail.com>
Acked-by: Hyong Youb Kim <hyonkim at cisco.com>
---
drivers/net/enic/enic_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index b755b15d92f..bcb319e1243 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1888,7 +1888,11 @@ static int enic_dev_init(struct enic *enic)
LIST_INIT(&enic->flows);
/* set up link status checking */
- vnic_dev_notify_set(enic->vdev, -1); /* No Intr for notify */
+ err = vnic_dev_notify_set(enic->vdev, -1); /* No Intr for notify */
+ if (err) {
+ dev_err(enic, "failed to enable notify buffer\n");
+ return err;
+ }
enic->overlay_offload = false;
/*
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:54.126664642 +0000
+++ 0009-net-enic-check-notify-set-return-value-during-init.patch 2026-10-27 11:43:53.498058954 +0000
@@ -1 +1 @@
-From 7b3647137055811a0f6d3fe43da517cf9ba11c9b Mon Sep 17 00:00:00 2001
+From b74997b5202d871f13289df4b6037de2cddcea1d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7b3647137055811a0f6d3fe43da517cf9ba11c9b ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 2696fa77d4..2a1a65d8da 100644
+index b755b15d92f..bcb319e1243 100644
@@ -27 +28 @@
-@@ -1887,7 +1887,11 @@ static int enic_dev_init(struct enic *enic)
+@@ -1888,7 +1888,11 @@ static int enic_dev_init(struct enic *enic)
More information about the stable
mailing list