patch 'net/txgbe: fix use-after-free in flow destroy' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:48:55 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/f5e2beae06bc41b25227ae53a3e36061e4c5f0bd
Thanks.
Luca Boccassi
---
>From f5e2beae06bc41b25227ae53a3e36061e4c5f0bd Mon Sep 17 00:00:00 2001
From: Tengfei Zhang <zhtfdev at gmail.com>
Date: Thu, 10 Sep 2026 21:39:41 +0800
Subject: [PATCH] net/txgbe: fix use-after-free in flow destroy
[ upstream commit d2e313e27fce74683785331587d042023343d9be ]
TAILQ_FOREACH advances via the current node's next pointer. Removing
and freeing that node inside the loop reads freed memory on the next
iteration.
Find the matching entry first, then remove it after the loop.
Fixes: e342da2d438f ("net/txgbe: support destroying consistent filter")
Signed-off-by: Tengfei Zhang <zhtfdev at gmail.com>
---
drivers/net/txgbe/txgbe_flow.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c
index cdd13ff5192..0459c7b54bb 100644
--- a/drivers/net/txgbe/txgbe_flow.c
+++ b/drivers/net/txgbe/txgbe_flow.c
@@ -3614,11 +3614,13 @@ txgbe_flow_destroy(struct rte_eth_dev *dev,
}
TAILQ_FOREACH(txgbe_flow_mem_ptr, &txgbe_flow_list, entries) {
- if (txgbe_flow_mem_ptr->flow == pmd_flow) {
- TAILQ_REMOVE(&txgbe_flow_list,
- txgbe_flow_mem_ptr, entries);
- rte_free(txgbe_flow_mem_ptr);
- }
+ if (txgbe_flow_mem_ptr->flow == pmd_flow)
+ break;
+ }
+ if (txgbe_flow_mem_ptr != NULL) {
+ TAILQ_REMOVE(&txgbe_flow_list,
+ txgbe_flow_mem_ptr, entries);
+ rte_free(txgbe_flow_mem_ptr);
}
rte_free(flow);
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:55.327581995 +0000
+++ 0041-net-txgbe-fix-use-after-free-in-flow-destroy.patch 2026-10-27 11:43:53.550060563 +0000
@@ -1 +1 @@
-From d2e313e27fce74683785331587d042023343d9be Mon Sep 17 00:00:00 2001
+From f5e2beae06bc41b25227ae53a3e36061e4c5f0bd Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d2e313e27fce74683785331587d042023343d9be ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 1bb0d3978c..eaeb973c91 100644
+index cdd13ff5192..0459c7b54bb 100644
@@ -24 +25 @@
-@@ -3667,11 +3667,13 @@ txgbe_flow_destroy(struct rte_eth_dev *dev,
+@@ -3614,11 +3614,13 @@ txgbe_flow_destroy(struct rte_eth_dev *dev,
More information about the stable
mailing list