patch 'bus/fslmc: fix signed comparison in buffer acquire' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:48:57 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/1c038daa48437ae4e55902ab267943575945a298

Thanks.

Luca Boccassi

---
>From 1c038daa48437ae4e55902ab267943575945a298 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Fri, 4 Sep 2026 12:12:37 -0700
Subject: [PATCH] bus/fslmc: fix signed comparison in buffer acquire

[ upstream commit 6c26b4781db482b05fdc3781adfbc9f34b14e083 ]

The acquired buffer count is masked with BMAN_VALID_RSLT_NUM_MASK so
it is always in the range 0..7, but it was held in an int and then
compared against the unsigned num_buffers parameter, giving a
-Wsign-compare warning in both acquire paths.

Make the count unsigned to match num_buffers.  The error paths return
negative errno values directly and are unaffected.

Fixes: a116979a03c6 ("bus/fslmc: improve BMAN buffer acquire")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 drivers/bus/fslmc/qbman/qbman_portal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c
index 5d0cedc136a..dff7a61a6be 100644
--- a/drivers/bus/fslmc/qbman/qbman_portal.c
+++ b/drivers/bus/fslmc/qbman/qbman_portal.c
@@ -2638,7 +2638,7 @@ static int qbman_swp_acquire_direct(struct qbman_swp *s, uint16_t bpid,
 {
 	struct qbman_acquire_desc *p;
 	struct qbman_acquire_rslt *r;
-	int num;
+	unsigned int num;
 
 	if (!num_buffers || (num_buffers > BMAN_VALID_RSLT_NUM_MASK))
 		return -EINVAL;
@@ -2685,7 +2685,7 @@ static int qbman_swp_acquire_cinh_direct(struct qbman_swp *s, uint16_t bpid,
 {
 	struct qbman_acquire_desc *p;
 	struct qbman_acquire_rslt *r;
-	int num;
+	unsigned int num;
 
 	if (!num_buffers || (num_buffers > BMAN_VALID_RSLT_NUM_MASK))
 		return -EINVAL;
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:43:55.399198351 +0000
+++ 0043-bus-fslmc-fix-signed-comparison-in-buffer-acquire.patch	2026-10-27 11:43:53.554060687 +0000
@@ -1 +1 @@
-From 6c26b4781db482b05fdc3781adfbc9f34b14e083 Mon Sep 17 00:00:00 2001
+From 1c038daa48437ae4e55902ab267943575945a298 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6c26b4781db482b05fdc3781adfbc9f34b14e083 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index c93bec5dd3..7b666d4ef9 100644
+index 5d0cedc136a..dff7a61a6be 100644
@@ -27 +28 @@
-@@ -2680,7 +2680,7 @@ static int qbman_swp_acquire_direct(struct qbman_swp *s, uint16_t bpid,
+@@ -2638,7 +2638,7 @@ static int qbman_swp_acquire_direct(struct qbman_swp *s, uint16_t bpid,
@@ -36 +37 @@
-@@ -2727,7 +2727,7 @@ static int qbman_swp_acquire_cinh_direct(struct qbman_swp *s, uint16_t bpid,
+@@ -2685,7 +2685,7 @@ static int qbman_swp_acquire_cinh_direct(struct qbman_swp *s, uint16_t bpid,


More information about the stable mailing list