patch 'net/i40e: fix error handling for QinQ filter' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:49:42 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/8581b5dd0f3c4232a470667510e6d8a2cf417b0f
Thanks.
Luca Boccassi
---
>From 8581b5dd0f3c4232a470667510e6d8a2cf417b0f Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Fri, 11 Sep 2026 10:40:43 +0100
Subject: [PATCH] net/i40e: fix error handling for QinQ filter
[ upstream commit 79ffb884262abe9caa297447b054b30057593969 ]
When installing a QinQ tunnel filter, errors were not properly caught
leading to the situation where the app got a successful return code even
though the filter was not properly installed. Add an appropriate log
message and error return code on error to fix.
Fixes: 116b7910d641 ("net/i40e: add QinQ filter create function")
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index d81dcffa308..c289b1bab0d 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -8665,9 +8665,11 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf,
case I40E_TUNNEL_TYPE_QINQ:
if (!pf->qinq_replace_flag) {
ret = i40e_cloud_filter_qinq_create(pf);
- if (ret < 0)
- PMD_DRV_LOG(DEBUG,
- "QinQ tunnel filter already created.");
+ if (ret < 0) {
+ PMD_DRV_LOG(ERR, "Failed to create QinQ tunnel filter.");
+ /* ret is a raw i40e_status_code, not an errno */
+ return -ENOTSUP;
+ }
pf->qinq_replace_flag = 1;
}
/* Add in the General fields the values of
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:57.107206963 +0000
+++ 0088-net-i40e-fix-error-handling-for-QinQ-filter.patch 2026-10-27 11:43:53.610062420 +0000
@@ -1 +1 @@
-From 79ffb884262abe9caa297447b054b30057593969 Mon Sep 17 00:00:00 2001
+From 8581b5dd0f3c4232a470667510e6d8a2cf417b0f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 79ffb884262abe9caa297447b054b30057593969 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -17 +18 @@
- drivers/net/intel/i40e/i40e_ethdev.c | 8 +++++---
+ drivers/net/i40e/i40e_ethdev.c | 8 +++++---
@@ -20,5 +21,5 @@
-diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c
-index ba1f170135..defdff0378 100644
---- a/drivers/net/intel/i40e/i40e_ethdev.c
-+++ b/drivers/net/intel/i40e/i40e_ethdev.c
-@@ -8613,9 +8613,11 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf,
+diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
+index d81dcffa308..c289b1bab0d 100644
+--- a/drivers/net/i40e/i40e_ethdev.c
++++ b/drivers/net/i40e/i40e_ethdev.c
+@@ -8665,9 +8665,11 @@ i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf,
More information about the stable
mailing list