patch 'net/intel: fix use of offload validation function' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:49:44 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/0a369930ac1d056ca4dac73a265d71b08f341958

Thanks.

Luca Boccassi

---
>From 0a369930ac1d056ca4dac73a265d71b08f341958 Mon Sep 17 00:00:00 2001
From: Omar Munchaev <omarmunchaev at gmail.com>
Date: Wed, 16 Sep 2026 19:29:04 +0300
Subject: [PATCH] net/intel: fix use of offload validation function

[ upstream commit 8099ff1275dab3e093c836c59ac99182be4d396c ]

rte_validate_tx_offload() returns 0 on success.  The i40e, iavf and ice
drivers treat any non-zero return as an error and drop the packet,
causing valid packets to be dropped when Tx offload checking is enabled
via EAL, e.g.:

    -a 81:00.0,mbuf_check=offload

Only reject the packet when the return value is not 0.

Fixes: 82b03af55a1b ("net/i40e: support mbuf checks in Tx path")
Fixes: 21dad1fc78cb ("net/iavf: support mbuf checks in Tx path")
Fixes: 2a0244d611b4 ("net/ice: support mbuf checks in Tx path")

Signed-off-by: Omar Munchaev <omarmunchaev at gmail.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 .mailmap                     | 1 +
 drivers/net/i40e/i40e_rxtx.c | 2 +-
 drivers/net/iavf/iavf_rxtx.c | 2 +-
 drivers/net/ice/ice_rxtx.c   | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.mailmap b/.mailmap
index d3fd2dd84c6..e56ac93dad0 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1184,6 +1184,7 @@ Olga Shern <olgas at nvidia.com> <olgas at mellanox.com>
 Olivier Gournet <ogournet at corp.free.fr>
 Olivier Matz <olivier.matz at 6wind.com>
 Omar Awaysa <omara at nvidia.com>
+Omar Munchaev <omarmunchaev at gmail.com>
 Omkar Maslekar <omkar.maslekar at intel.com>
 Omri Mor <omrimor2 at illinois.edu>
 Ophir Munk <ophirmu at nvidia.com> <ophirmu at mellanox.com>
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 5b8cbf3f0d9..a7feb831759 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1637,7 +1637,7 @@ i40e_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts
 				break;
 			}
 
-			if (!rte_validate_tx_offload(mb)) {
+			if (rte_validate_tx_offload(mb) != 0) {
 				PMD_TX_LOG(ERR, "INVALID mbuf: TX offload setup error");
 				pkt_error = true;
 				break;
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 5343bf02c18..7add7e7a9a0 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -3872,7 +3872,7 @@ iavf_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts,
 				break;
 			}
 
-			if (!rte_validate_tx_offload(mb)) {
+			if (rte_validate_tx_offload(mb) != 0) {
 				PMD_TX_LOG(ERR, "INVALID mbuf: TX offload setup error");
 				pkt_error = true;
 				break;
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 417dc80a3a8..d01023fa875 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3807,7 +3807,7 @@ ice_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 				break;
 			}
 
-			if (!rte_validate_tx_offload(mb)) {
+			if (rte_validate_tx_offload(mb) != 0) {
 				PMD_TX_LOG(ERR, "INVALID mbuf: TX offload setup error");
 				pkt_error = true;
 				break;
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:43:57.196189912 +0000
+++ 0090-net-intel-fix-use-of-offload-validation-function.patch	2026-10-27 11:43:53.614062544 +0000
@@ -1 +1 @@
-From 8099ff1275dab3e093c836c59ac99182be4d396c Mon Sep 17 00:00:00 2001
+From 0a369930ac1d056ca4dac73a265d71b08f341958 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8099ff1275dab3e093c836c59ac99182be4d396c ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -23,4 +24,4 @@
- .mailmap                           | 1 +
- drivers/net/intel/i40e/i40e_rxtx.c | 2 +-
- drivers/net/intel/iavf/iavf_rxtx.c | 2 +-
- drivers/net/intel/ice/ice_rxtx.c   | 2 +-
+ .mailmap                     | 1 +
+ drivers/net/i40e/i40e_rxtx.c | 2 +-
+ drivers/net/iavf/iavf_rxtx.c | 2 +-
+ drivers/net/ice/ice_rxtx.c   | 2 +-
@@ -30 +31 @@
-index 2c2c12091e..cf7e9c293c 100644
+index d3fd2dd84c6..e56ac93dad0 100644
@@ -33 +34 @@
-@@ -1245,6 +1245,7 @@ Olga Shern <olgas at nvidia.com> <olgas at mellanox.com>
+@@ -1184,6 +1184,7 @@ Olga Shern <olgas at nvidia.com> <olgas at mellanox.com>
@@ -41,5 +42,5 @@
-diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
-index f289d26790..8bfd1e07d2 100644
---- a/drivers/net/intel/i40e/i40e_rxtx.c
-+++ b/drivers/net/intel/i40e/i40e_rxtx.c
-@@ -1196,7 +1196,7 @@ i40e_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts
+diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
+index 5b8cbf3f0d9..a7feb831759 100644
+--- a/drivers/net/i40e/i40e_rxtx.c
++++ b/drivers/net/i40e/i40e_rxtx.c
+@@ -1637,7 +1637,7 @@ i40e_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts
@@ -54,5 +55,5 @@
-diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c
-index 9b776a6391..fc47a2cf1a 100644
---- a/drivers/net/intel/iavf/iavf_rxtx.c
-+++ b/drivers/net/intel/iavf/iavf_rxtx.c
-@@ -3819,7 +3819,7 @@ iavf_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts,
+diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
+index 5343bf02c18..7add7e7a9a0 100644
+--- a/drivers/net/iavf/iavf_rxtx.c
++++ b/drivers/net/iavf/iavf_rxtx.c
+@@ -3872,7 +3872,7 @@ iavf_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts,
@@ -67,5 +68,5 @@
-diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
-index 2db1fe16bf..b333444cbf 100644
---- a/drivers/net/intel/ice/ice_rxtx.c
-+++ b/drivers/net/intel/ice/ice_rxtx.c
-@@ -3700,7 +3700,7 @@ ice_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
+diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
+index 417dc80a3a8..d01023fa875 100644
+--- a/drivers/net/ice/ice_rxtx.c
++++ b/drivers/net/ice/ice_rxtx.c
+@@ -3807,7 +3807,7 @@ ice_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)


More information about the stable mailing list