patch 'net/bnxt: fix integer overflow in device reset' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:49:48 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/d37828a18dc5fb50b350bb70c5365dd513953096

Thanks.

Luca Boccassi

---
>From d37828a18dc5fb50b350bb70c5365dd513953096 Mon Sep 17 00:00:00 2001
From: Denis Lyulin <lyulin.2003 at mail.ru>
Date: Fri, 17 Apr 2026 08:23:33 +0300
Subject: [PATCH] net/bnxt: fix integer overflow in device reset

[ upstream commit b55198c5834ad314757e7c8456f8becd3e14fdb9 ]

Some static analyzers generate warnings about possible integer
overflow on multiplication. The first parameter of
`rte_eal_alarm_set()` is `uint64_t`, so this commit adds cast
of `uint32_t` values before the multiplication to prevent overflow.
The fix is cosmetic.

Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring")

Signed-off-by: Denis Lyulin <lyulin.2003 at mail.ru>
---
 drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index eec9003d693..5603cff823d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4648,7 +4648,7 @@ err:
 void bnxt_dev_reset_and_resume(void *arg)
 {
 	struct bnxt *bp = arg;
-	uint32_t us = US_PER_MS * bp->fw_reset_min_msecs;
+	uint64_t us = US_PER_MS * (uint64_t)bp->fw_reset_min_msecs;
 	uint16_t val = 0;
 	int rc;
 
@@ -4795,7 +4795,7 @@ static void bnxt_check_fw_health(void *arg)
 
 	info->last_reset_counter = val;
 
-	rte_eal_alarm_set(US_PER_MS * info->driver_polling_freq,
+	rte_eal_alarm_set(US_PER_MS * (uint64_t)info->driver_polling_freq,
 			  bnxt_check_fw_health, (void *)bp);
 
 	return;
@@ -4817,7 +4817,7 @@ reset:
 	else
 		wait_msec = info->normal_func_wait_period;
 
-	rte_eal_alarm_set(US_PER_MS * wait_msec,
+	rte_eal_alarm_set(US_PER_MS * (uint64_t)wait_msec,
 			  bnxt_fw_reset_cb, (void *)bp);
 }
 
@@ -4835,7 +4835,7 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)
 
 	polling_freq = bp->recovery_info->driver_polling_freq;
 
-	rte_eal_alarm_set(US_PER_MS * polling_freq,
+	rte_eal_alarm_set(US_PER_MS * (uint64_t)polling_freq,
 			  bnxt_check_fw_health, (void *)bp);
 	bp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;
 
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:43:57.355334522 +0000
+++ 0094-net-bnxt-fix-integer-overflow-in-device-reset.patch	2026-10-27 11:43:53.618062667 +0000
@@ -1 +1 @@
-From b55198c5834ad314757e7c8456f8becd3e14fdb9 Mon Sep 17 00:00:00 2001
+From d37828a18dc5fb50b350bb70c5365dd513953096 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b55198c5834ad314757e7c8456f8becd3e14fdb9 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 178814509e..51dbb50b8b 100644
+index eec9003d693..5603cff823d 100644
@@ -24 +25 @@
-@@ -4722,7 +4722,7 @@ err:
+@@ -4648,7 +4648,7 @@ err:
@@ -33 +34 @@
-@@ -4869,7 +4869,7 @@ static void bnxt_check_fw_health(void *arg)
+@@ -4795,7 +4795,7 @@ static void bnxt_check_fw_health(void *arg)
@@ -42 +43 @@
-@@ -4891,7 +4891,7 @@ reset:
+@@ -4817,7 +4817,7 @@ reset:
@@ -51 +52 @@
-@@ -4909,7 +4909,7 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)
+@@ -4835,7 +4835,7 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)


More information about the stable mailing list