patch 'hash: fix GFNI helpers for building with -O0' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:50:06 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/c659f16bc2822d2a823a343850a3a8e755217acd
Thanks.
Luca Boccassi
---
>From c659f16bc2822d2a823a343850a3a8e755217acd Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Wed, 30 Sep 2026 09:38:53 +0200
Subject: [PATCH] hash: fix GFNI helpers for building with -O0
[ upstream commit 04d091fe4cc5229e5fa8e13d1a9e38a8bf1cfb3d ]
Similarly to commit da31ef54c865 ("hash: fix GFNI stubs export"),
fix "internal" helpers used by public inline helpers by removing the
incorrect __rte_internal annotation.
The issue is usually not seen as those helpers get inlined under
standard compiler optimization level, but it becomes visible when
building with -O0.
Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")
Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
lib/hash/rte_thash_x86_gfni.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h
index 69973503fdb..e5abdf2474f 100644
--- a/lib/hash/rte_thash_x86_gfni.h
+++ b/lib/hash/rte_thash_x86_gfni.h
@@ -13,7 +13,6 @@
*/
#include <rte_bitops.h>
-#include <rte_compat.h>
#include <rte_vect.h>
#ifdef __cplusplus
@@ -29,7 +28,6 @@ extern "C" {
#define RTE_THASH_PERM_MSK_2 0xf0f0f0f0f0f0f0f0
#define RTE_THASH_REWIND_MSK 0x0000000000113377
-__rte_internal
static inline void
__rte_thash_xor_reduce(__m512i xor_acc, uint32_t *val_1, uint32_t *val_2)
{
@@ -64,7 +62,6 @@ __rte_thash_xor_reduce(__m512i xor_acc, uint32_t *val_1, uint32_t *val_2)
#endif
}
-__rte_internal
static inline __m512i
__rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,
const uint8_t *secondary_tuple, int len)
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:58.073675803 +0000
+++ 0112-hash-fix-GFNI-helpers-for-building-with-O0.patch 2026-10-27 11:43:53.646063535 +0000
@@ -1 +1 @@
-From 04d091fe4cc5229e5fa8e13d1a9e38a8bf1cfb3d Mon Sep 17 00:00:00 2001
+From c659f16bc2822d2a823a343850a3a8e755217acd Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 04d091fe4cc5229e5fa8e13d1a9e38a8bf1cfb3d ]
+
@@ -23 +25 @@
-index 69973503fd..e5abdf2474 100644
+index 69973503fdb..e5abdf2474f 100644
More information about the stable
mailing list