patch 'net/gve: fix RSS config memory leak on close' has been queued to stable release 24.11.9
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Tue Oct 27 12:50:32 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/d1d03a88ecfe7e3b069f1bfdf477a04c97972b9b
Thanks.
Luca Boccassi
---
>From d1d03a88ecfe7e3b069f1bfdf477a04c97972b9b Mon Sep 17 00:00:00 2001
From: Jasper Tran O'Leary <jtranoleary at google.com>
Date: Fri, 9 Oct 2026 17:59:33 -0700
Subject: [PATCH] net/gve: fix RSS config memory leak on close
[ upstream commit 233728918e91fd7ca40272495866dcbb975b3bd1 ]
Free rss_config resources during device close to avoid leaking
redirection table and hash key memory. Also, memset the entire
gve_rss_config struct to 0 to avoid leaking RSS hash function or hash
types.
Fixes: 63ef54569760 ("net/gve: support RSS configuration update")
Signed-off-by: Jasper Tran O'Leary <jtranoleary at google.com>
Signed-off-by: Joshua Washington <joshwash at google.com>
---
drivers/net/gve/gve_ethdev.c | 1 +
drivers/net/gve/gve_rss.c | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index 3596a0236d3..79f2854d509 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -524,6 +524,7 @@ gve_teardown_device_resources(struct gve_priv *priv)
gve_free_ptype_lut_dqo(priv);
gve_free_counter_array(priv);
gve_free_irq_db(priv);
+ gve_free_rss_config(&priv->rss_config);
gve_clear_device_resources_ok(priv);
}
diff --git a/drivers/net/gve/gve_rss.c b/drivers/net/gve/gve_rss.c
index 931180f8f25..45c989b0d38 100644
--- a/drivers/net/gve/gve_rss.c
+++ b/drivers/net/gve/gve_rss.c
@@ -71,9 +71,8 @@ void
gve_free_rss_config(struct gve_rss_config *gve_rss_conf)
{
rte_free(gve_rss_conf->indir);
- gve_rss_conf->indir = NULL;
rte_free(gve_rss_conf->key);
- gve_rss_conf->key = NULL;
+ memset(gve_rss_conf, 0, sizeof(*gve_rss_conf));
}
int
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-10-27 11:43:59.009689814 +0000
+++ 0138-net-gve-fix-RSS-config-memory-leak-on-close.patch 2026-10-27 11:43:53.662064030 +0000
@@ -1 +1 @@
-From 233728918e91fd7ca40272495866dcbb975b3bd1 Mon Sep 17 00:00:00 2001
+From d1d03a88ecfe7e3b069f1bfdf477a04c97972b9b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 233728918e91fd7ca40272495866dcbb975b3bd1 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index c990920a4d..80623979a8 100644
+index 3596a0236d3..79f2854d509 100644
@@ -25 +26 @@
-@@ -699,6 +699,7 @@ gve_teardown_device_resources(struct gve_priv *priv)
+@@ -524,6 +524,7 @@ gve_teardown_device_resources(struct gve_priv *priv)
@@ -34 +35 @@
-index 67b910ed22..4084d7955f 100644
+index 931180f8f25..45c989b0d38 100644
More information about the stable
mailing list