patch 'net/ice: check for missing fixed speed setting' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:50:38 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/1577d035612a55220276c79d6169172b15406446

Thanks.

Luca Boccassi

---
>From 1577d035612a55220276c79d6169172b15406446 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Thu, 10 Sep 2026 16:08:16 +0100
Subject: [PATCH] net/ice: check for missing fixed speed setting

[ upstream commit 45c23136c1908491c1ead7a52204164be8105eb8 ]

When the user requests a fixed speed for a NIC link, the speeds bitmask
passed must have a speed value actually set in it, as well as the
"FIXED" flag. Catch this case and log an error message.

Fixes: 36afbc269081 ("net/ice: support link speed change")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
---
 drivers/net/ice/ice_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 30803dd9544..81f1ca51644 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4408,6 +4408,10 @@ ice_apply_link_speed(struct rte_eth_dev *dev)
 					RTE_ETH_LINK_SPEED_100M;
 	}
 	speed = ice_parse_link_speeds(conf->link_speeds);
+	if (speed == ICE_AQ_LINK_SPEED_UNKNOWN) {
+		PMD_DRV_LOG(ERR, "No valid link speed setting specified");
+		return -EINVAL;
+	}
 
 	return ice_phy_conf_link(hw, speed, true);
 }
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:43:59.233522980 +0000
+++ 0144-net-ice-check-for-missing-fixed-speed-setting.patch	2026-10-27 11:43:53.670064277 +0000
@@ -1 +1 @@
-From 45c23136c1908491c1ead7a52204164be8105eb8 Mon Sep 17 00:00:00 2001
+From 1577d035612a55220276c79d6169172b15406446 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 45c23136c1908491c1ead7a52204164be8105eb8 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- drivers/net/intel/ice/ice_ethdev.c | 4 ++++
+ drivers/net/ice/ice_ethdev.c | 4 ++++
@@ -19,5 +20,5 @@
-diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
-index dfee07c457..d5e177f687 100644
---- a/drivers/net/intel/ice/ice_ethdev.c
-+++ b/drivers/net/intel/ice/ice_ethdev.c
-@@ -5038,6 +5038,10 @@ ice_apply_link_speed(struct rte_eth_dev *dev)
+diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
+index 30803dd9544..81f1ca51644 100644
+--- a/drivers/net/ice/ice_ethdev.c
++++ b/drivers/net/ice/ice_ethdev.c
+@@ -4408,6 +4408,10 @@ ice_apply_link_speed(struct rte_eth_dev *dev)


More information about the stable mailing list