patch 'net/bnxt: check packet type indexing for v3 completion' has been queued to stable release 24.11.9

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Oct 27 12:51:04 CET 2026


Hi,

FYI, your patch has been queued to stable release 24.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/29/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/fb809f01fec18a90f4f237c1eafdbee7bde5aed1

Thanks.

Luca Boccassi

---
>From fb809f01fec18a90f4f237c1eafdbee7bde5aed1 Mon Sep 17 00:00:00 2001
From: Farah Smith <farah.smith at broadcom.com>
Date: Wed, 9 Sep 2026 10:54:40 -0600
Subject: [PATCH] net/bnxt: check packet type indexing for v3 completion

[ upstream commit 38e0e327813554029e5806bfb779dee690561910 ]

The Thor2/P7 (V3 completion) receive path left a TODO instead of
calling a build-time validation of the ptype lookup table indexing,
unlike the equivalent V2 completion path which already validates its
own index layout via bnxt_check_ptype_constants(). Without it, any
future drift between the V3 completion field shift/mask definitions
and the ptype table's index layout would silently produce an
out-of-bounds ptype table index at runtime instead of being caught
at compile time.

Add bnxt_check_ptype_constants_v3(), mirroring the existing V2
helper, and call it from bnxt_parse_pkt_type_v3() via
RTE_BUILD_BUG_ON.

Fixes: 65d2b0557ba3 ("net/bnxt: support Rx completion v3")

Signed-off-by: Farah Smith <farah.smith at broadcom.com>
Signed-off-by: Mohammad Shuab Siddique <mohammad-shuab.siddique at broadcom.com>
---
 drivers/net/bnxt/bnxt_rxr.c |  3 +--
 drivers/net/bnxt/bnxt_rxr.h | 11 +++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index e5681d39243..52f64191db4 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -592,9 +592,8 @@ bnxt_parse_pkt_type_v3(struct rte_mbuf *mbuf,
 	flags2 = rte_le_to_cpu_32(rxcmp1->flags2);
 	meta = rte_le_to_cpu_32(rxcmp->metadata1_payload_offset);
 
-	/* TODO */
 	/* Validate ptype table indexing at build time. */
-	/* bnxt_check_ptype_constants_v3(); */
+	bnxt_check_ptype_constants_v3();
 
 	/*
 	 * Index format:
diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
index f6d1e3ddfba..cbafb8873ce 100644
--- a/drivers/net/bnxt/bnxt_rxr.h
+++ b/drivers/net/bnxt/bnxt_rxr.h
@@ -462,6 +462,17 @@ bnxt_parse_pkt_type_v2(struct rte_mbuf *mbuf,
 	(((f2) & RX_PKT_V3_CMPL_HI_FLAGS2_IP_TYPE) >> \
 	 (RX_PKT_V3_CMPL_FLAGS2_IP_TYPE_SFT - BNXT_PTYPE_TBL_IP_VER_SFT))
 
+static inline void
+bnxt_check_ptype_constants_v3(void)
+{
+	RTE_BUILD_BUG_ON(BNXT_CMPL_V3_ITYPE_TO_IDX(RX_PKT_V3_CMPL_FLAGS_ITYPE_MASK) !=
+			 BNXT_PTYPE_TBL_TYPE_MSK);
+	RTE_BUILD_BUG_ON(BNXT_CMPL_V3_VLAN_TO_IDX(RX_PKT_V3_CMPL_METADATA1_VALID) !=
+			 BNXT_PTYPE_TBL_VLAN_MSK);
+	RTE_BUILD_BUG_ON(BNXT_CMPL_V3_IP_VER_TO_IDX(RX_PKT_V3_CMPL_HI_FLAGS2_IP_TYPE) !=
+			 BNXT_PTYPE_TBL_IP_VER_MSK);
+}
+
 #define RX_CMP_V3_VLAN_VALID(rxcmp)        \
 	(((struct rx_pkt_v3_cmpl *)rxcmp)->metadata1_payload_offset &	\
 	 RX_PKT_V3_CMPL_METADATA1_VALID)
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-10-27 11:44:00.244031624 +0000
+++ 0170-net-bnxt-check-packet-type-indexing-for-v3-completio.patch	2026-10-27 11:43:53.754066877 +0000
@@ -1 +1 @@
-From 38e0e327813554029e5806bfb779dee690561910 Mon Sep 17 00:00:00 2001
+From fb809f01fec18a90f4f237c1eafdbee7bde5aed1 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 38e0e327813554029e5806bfb779dee690561910 ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org
@@ -30 +31 @@
-index 7a962ce9ab..559c208437 100644
+index e5681d39243..52f64191db4 100644
@@ -33 +34 @@
-@@ -583,9 +583,8 @@ bnxt_parse_pkt_type_v3(struct rte_mbuf *mbuf,
+@@ -592,9 +592,8 @@ bnxt_parse_pkt_type_v3(struct rte_mbuf *mbuf,
@@ -45 +46 @@
-index c82f44f041..f38fb4f0ba 100644
+index f6d1e3ddfba..cbafb8873ce 100644
@@ -48 +49 @@
-@@ -475,6 +475,17 @@ bnxt_parse_pkt_type_v2(struct rte_mbuf *mbuf,
+@@ -462,6 +462,17 @@ bnxt_parse_pkt_type_v2(struct rte_mbuf *mbuf,


More information about the stable mailing list