[PATCH v7 2/4] net/iavf: fix duplicate MAC addresses install
David Marchand
david.marchand at redhat.com
Mon Sep 14 14:27:49 CEST 2026
On Mon, 14 Sept 2026 at 14:02, Bruce Richardson
<bruce.richardson at intel.com> wrote:
> On Mon, Sep 14, 2026 at 01:56:36PM +0200, David Marchand wrote:
> > On Mon, 14 Sept 2026 at 12:19, Loftus, Ciara <ciara.loftus at intel.com> wrote:
> > > > @@ -3428,6 +3428,14 @@ iavf_post_reset_reconfig(struct rte_eth_dev
> > > > *dev)
> > > > int ret = 0;
> > > > bool allmulti = false, allunicast = false;
> > > > struct iavf_adapter *adapter = IAVF_DEV_PRIVATE_TO_ADAPTER(dev-
> > > > >data->dev_private);
> > > > + struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data-
> > > > >dev_private);
> > > > +
> > > > + /*
> > > > + * After a VF reset, all MAC addresses got flushed.
> > > > + * The primary MAC should have been set in iavf_dev_start, restore
> > >
> > > iavf_dev_start is not guaranteed to have been executed before this handler.
> > > So I would change this comment to something like:
> > > "The primary MAC has been or will be restored by iavf_dev_start".
> > >
> > > Other than that:
> > >
> > > Acked-by: Ciara Loftus <ciara.loftus at intel.com>
> >
> > Yes, true.
> > I'll update in a new revision if needed, otherwise, could it be
> > updated when applying?
> >
> Single line text changes I can handle on apply, no problem, so long as the
> rest of the set is good to go.
Yes, sure.
Thanks Bruce.
--
David Marchand
More information about the stable
mailing list