[dpdk-test-report] |WARNING| pw18551 [PATCH v2 07/17] net/i40e: add flow validate function

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Dec 27 07:27:58 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18551

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#243: FILE: drivers/net/i40e/i40e_flow.c:110:
+	if (ethertype_filter->ether_type == ETHER_TYPE_IPv4 ||

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#244: FILE: drivers/net/i40e/i40e_flow.c:111:
+	    ethertype_filter->ether_type == ETHER_TYPE_IPv6) {

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

total: 0 errors, 0 warnings, 7 checks, 485 lines checked


More information about the test-report mailing list