[dpdk-test-report] [PatchWork]|ERROR| pw13152-13157 virtio, qtest: Add QTest utility basic functions

sys_stv at intel.com sys_stv at intel.com
Thu Jun 2 10:54:50 CEST 2016


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13152-13157
http://www.dpdk.org/dev/patchwork/patch/13157/
Submitter: Tetsuya Mukawa <mukawa at igel.co.jp>
Date: Thu,  2 Jun 2016 12:29:40 +0900
DPDK git baseline: c8c33ad7f94c59d1c0676af0cfd61207b3e808db

Check patch error:
#161: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:102:
+                       if (errno == EINTR) {
+                               continue;
+                       }

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#452: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:393:
+               return -1;
                       ^
   
   WARNING:LONG_LINE: line over 80 characters
   #461: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:402:
   +                * In our case, after connecting ivshmem socket, we may need to wait
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #474: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:415:
   +               return -1;
                          ^
  
  total: 2 errors, 2 warnings, 614 lines checked
  
  NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
  
  13152 has style problems, please review.
  
  If any of these errors are false positives, please report
  them to the maintainer, see CHECKPATCH in MAINTAINERS.
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #214: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:538:
  +               return -1;
                         ^
 
 WARNING:LONG_LINE: line over 80 characters
 #290: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:614:
 +                               dev->bar[i].region_start + dev->bar[i].region_size);
 
 WARNING:LONG_LINE: line over 80 characters
 #297: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:621:
 +                               dev->bar[i].region_start + dev->bar[i].region_size);
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #331: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:655:
 +       return -1;
                ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#346: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:670:
+                       return -1;
                               ^
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #384: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:708:
   +                       return -1;
                                  ^
  
  total: 4 errors, 2 warnings, 534 lines checked
  
  NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
  
  13153 has style problems, please review.
  
  If any of these errors are false positives, please report
  them to the maintainer, see CHECKPATCH in MAINTAINERS.
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #128: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:791:
  +               return -1;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #175: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:838:
 +       return -1;
                ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#188: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:851:
+               return -1;
                       ^
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #195: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:858:
   +               return -1;
                          ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #204: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:867:
  +               return -1;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #211: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:874:
 +               return -1;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#218: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:881:
+               return -1;
                       ^
   
   total: 7 errors, 0 warnings, 249 lines checked
   
   NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
   
   13154 has style problems, please review.
   
   If any of these errors are false positives, please report
   them to the maintainer, see CHECKPATCH in MAINTAINERS.
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #51: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:406:
   +               return -1;
                          ^
  
  ERROR:SPACING: need consistent spacing around '&' (ctx:WxV)
  #83: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:438:
  +       return &dev->bar[bar];
                 ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #94: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:449:
 +               return -1;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#108: FILE: drivers/net/virtio/virtio_qtest/qtest_utils.c:463:
+               return -1;
                       ^
   
   total: 4 errors, 0 warnings, 145 lines checked
   
   NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
   
   13155 has style problems, please review.
   
   If any of these errors are false positives, please report
   them to the maintainer, see CHECKPATCH in MAINTAINERS.
   WARNING:LONG_LINE: line over 80 characters
   #164: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_pci.c:118:
   +                       *p++ = qtest_read8(hw, (uint8_t *)hw->dev_cfg + offset + i);
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #253: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_pci.c:207:
   +               return -1;
                          ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #373: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_pci.c:327:
  +               return -1;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #421: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_pci.c:375:
 +               return -1;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#452: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_pci.c:406:
+       return -EFAULT;
               ^
   
   total: 4 errors, 1 warnings, 453 lines checked
   
   NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
   
   13156 has style problems, please review.
   
   If any of these errors are false positives, please report
   them to the maintainer, see CHECKPATCH in MAINTAINERS.
   WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
   #288: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:55:
   +static const char *valid_qtest_args[] = {
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #303: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:70:
   +               return -EINVAL;
                          ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #309: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:76:
  +               return -1;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #321: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:88:
 +               return -EINVAL;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#324: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:91:
+               return -1;
                       ^
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #327: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:94:
   +               return -1;
                          ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #341: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:108:
  +               return -1;
                         ^
 
 WARNING:LONG_LINE: line over 80 characters
 #396: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:163:
 +                                       "Failed to connect to %s socket", option);
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #397: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:164:
 +                       return -1;
                                ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#401: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:168:
+               return -1;
                       ^
   
   WARNING:LONG_LINE: line over 80 characters
   #419: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:186:
   +                                       "Specified invalid address in '%s'", option);
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #420: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:187:
   +                       return -1;
                                  ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #442: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:209:
  +               return -1;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #448: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:215:
 +               return -1;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#455: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:222:
+               return -1;
                       ^
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #501: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:268:
   +               return -1;
                          ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #508: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:275:
  +               return -1;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #526: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:293:
 +               return -EINVAL;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#531: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:298:
+               return -EFAULT;
                       ^
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #587: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:354:
   +       return -EFAULT;
                  ^
  
  ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
  #598: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:365:
  +               return -EINVAL;
                         ^
 
 ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
 #603: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:370:
 +               return -ENODEV;
                        ^

ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
#607: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:374:
+               return -EFAULT;
                       ^
   
   ERROR:SPACING: need consistent spacing around '-' (ctx:WxV)
   #614: FILE: drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c:381:
   +               return -EFAULT;
                          ^
  
  total: 21 errors, 3 warnings, 575 lines checked
  
  NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
  
  13157 has style problems, please review.

patch file error:
13152: 
patching file config/common_linuxapp
Hunk #1 FAILED at 46.
1 out of 1 hunk FAILED -- saving rejects to file config/common_linuxapp.rej patching file drivers/net/virtio/Makefile Hunk #1 succeeded at 55 with fuzz 1 (offset -8 lines).
patching file drivers/net/virtio/virtio_qtest/qtest_utils.c
patching file drivers/net/virtio/virtio_qtest/qtest_utils.h

13157: 
patching file drivers/net/virtio/Makefile Hunk #1 succeeded at 58 (offset -8 lines).
patching file drivers/net/virtio/virtio_ethdev.c
Hunk #1 FAILED at 59.
Hunk #2 succeeded at 1167 (offset -12 lines).
1 out of 2 hunks FAILED -- saving rejects to file drivers/net/virtio/virtio_ethdev.c.rej
patching file drivers/net/virtio/virtio_ethdev.h
Hunk #1 FAILED at 114.
1 out of 1 hunk FAILED -- saving rejects to file drivers/net/virtio/virtio_ethdev.h.rej
patching file drivers/net/virtio/virtio_qtest/qtest.h
patching file drivers/net/virtio/virtio_qtest/virtio_qtest_dev.c
patching file drivers/net/virtio/virtio_qtest/virtio_qtest_dev.h
patching file drivers/net/virtio/virtqueue.h Hunk #1 FAILED at 66.
1 out of 1 hunk FAILED -- saving rejects to file drivers/net/virtio/virtqueue.h.rej

DPDK STV team 

  


More information about the test-report mailing list