[dpdk-test-report] [PatchWork]|ERROR| pw13292-13299 lib/librte_ether: support device reset

sys_stv at intel.com sys_stv at intel.com
Sun Jun 12 03:58:56 CEST 2016


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13292-13299
http://www.dpdk.org/dev/patchwork/patch/13299/
Submitter: Zhe Tao <zhe.tao at intel.com>
Date: Tue,  7 Jun 2016 14:53:03 +0800
DPDK git baseline: dd9ae4c7b302dffd9b3dac849f4da8badac91719

Check patch error:
13297: 
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#123: FILE: drivers/net/e1000/e1000_ethdev.h:324:
+volatile union e1000_adv_rx_desc *rx_ring; /**< RX ring virtual 
+address. */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#125: FILE: drivers/net/e1000/e1000_ethdev.h:326:
+volatile uint32_t   *rdt_reg_addr; /**< RDT register address. */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#126: FILE: drivers/net/e1000/e1000_ethdev.h:327:
+volatile uint32_t   *rdh_reg_addr; /**< RDH register address. */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#149: FILE: drivers/net/e1000/e1000_ethdev.h:350:
+volatile union e1000_adv_tx_desc *tx_ring; /**< TX ring address */

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#152: FILE: drivers/net/e1000/e1000_ethdev.h:353:
+volatile uint32_t      *tdt_reg_addr; /**< Address of TDT register. */

WARNING: quoted string split across lines
#262: FILE: drivers/net/e1000/igb_ethdev.c:2717:
+PMD_INIT_LOG(INFO, "Igb VF reset: "
+     "Failed to update link.");

WARNING: quoted string split across lines
#269: FILE: drivers/net/e1000/igb_ethdev.c:2724:
+PMD_INIT_LOG(ERR, "Igb VF reset: "
+     "Failed to start device.");

WARNING: quoted string split across lines
#278: FILE: drivers/net/e1000/igb_ethdev.c:2733:
+PMD_INIT_LOG(INFO, "Igb VF reset: "
+     "Failed to update link.");

ERROR: need consistent spacing around '*' (ctx:WxV)
#458: FILE: drivers/net/e1000/igb_rxtx.c:2432:
+eth_igbvf_xmit_pkts_fake(void __rte_unused *tx_queue,
                                            ^

ERROR: need consistent spacing around '*' (ctx:WxO)
#459: FILE: drivers/net/e1000/igb_rxtx.c:2433:
+ struct rte_mbuf __rte_unused **tx_pkts,
                              ^
  
  ERROR: need consistent spacing around '*' (ctx:WxV)
  #469: FILE: drivers/net/e1000/igb_rxtx.c:2443:
  +eth_igbvf_recv_pkts_fake(void __rte_unused *rx_queue,
                                              ^
  
  ERROR: need consistent spacing around '*' (ctx:WxO)
  #470: FILE: drivers/net/e1000/igb_rxtx.c:2444:
  + struct rte_mbuf __rte_unused **rx_pkts,
                              ^
  
  total: 4 errors, 8 warnings, 413 lines checked
  
  /home/patchWorkOrg/patches/dpdk-dev-v4-6-8-igb-implement-device-reset-on-VF.patch has style problems, please review.
  
  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
  
  13299: 
  ERROR: need consistent spacing around '*' (ctx:WxV)
  #161: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1377:
  +i40evf_recv_pkts_detach(void __rte_unused *rx_queue,
                                             ^
 
 ERROR: need consistent spacing around '*' (ctx:WxO)
 #162: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1378:
 +struct rte_mbuf __rte_unused **rx_pkts,
                             ^
 
 ERROR: need consistent spacing around '*' (ctx:WxV)
 #169: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1385:
 +i40evf_xmit_pkts_detach(void __rte_unused *tx_queue,
                                            ^

ERROR: need consistent spacing around '*' (ctx:WxO)
#170: FILE: drivers/net/i40e/i40e_ethdev_vf.c:1386:
+struct rte_mbuf __rte_unused **tx_pkts,
                             ^
 
 total: 4 errors, 0 warnings, 268 lines checked
 
 /home/patchWorkOrg/patches/dpdk-dev-v4-8-8-i40e-implement-device-reset-on-VF.patch has style problems, please review.
 
 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
 
 13292: 
 ERROR: spaces prohibited around that ':' (ctx:WxW)
 #40: FILE: lib/librte_ether/rte_ethdev.h:360:
 +enable_lro       : 1, /**< Enable LRO */
                 ^
 
 ERROR: spaces prohibited around that ':' (ctx:WxW)
 #41: FILE: lib/librte_ether/rte_ethdev.h:361:
 +lock_mode        : 1; /**< Using lock path */
                 ^
 
 ERROR: spaces prohibited around that ':' (ctx:WxW)
 #54: FILE: lib/librte_ether/rte_ethdev.h:646:
 +hw_vlan_insert_pvid : 1,
                    ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#56: FILE: lib/librte_ether/rte_ethdev.h:648:
+lock_mode : 1;
          ^
  
  total: 4 errors, 0 warnings, 80 lines checked
  
  /home/patchWorkOrg/patches/dpdk-dev-v4-2-8-lib-librte_ether-defind-RX-TX-lock-mode.patch has style problems, please review.
  
  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
  
  13294: 
  ERROR: need consistent spacing around '*' (ctx:WxV)
  #292: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5263:
  +void __rte_unused *rx_queue,
                  ^
  
  ERROR: need consistent spacing around '*' (ctx:WxO)
  #293: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5264:
  +struct rte_mbuf __rte_unused **rx_pkts,
                             ^
 
 ERROR: need consistent spacing around '*' (ctx:WxV)
 #309: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5281:
 +void __rte_unused *rx_queue,
                  ^
  
  ERROR: need consistent spacing around '*' (ctx:WxO)
  #310: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5282:
  +struct rte_mbuf __rte_unused **rx_pkts,
                             ^
 
 total: 4 errors, 0 warnings, 322 lines checked
 
 /home/patchWorkOrg/patches/dpdk-dev-v4-3-8-ixgbe-RX-TX-with-lock-on-VF.patch has style problems, please review.
 
 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
 
 13295: 
 WARNING: quoted string split across lines
 #133: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:7246:
 +PMD_INIT_LOG(INFO, "Ixgbe VF reset: "
 +     "Failed to update link.");
 
 WARNING: quoted string split across lines
 #141: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:7254:
 +PMD_INIT_LOG(ERR, "Ixgbe VF reset: "
 +     "Failed to start device.");
 
 WARNING: quoted string split across lines
 #150: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:7263:
 +PMD_INIT_LOG(INFO, "Ixgbe VF reset: "
 +     "Failed to update link.");
 
 ERROR: need consistent spacing around '*' (ctx:WxV)
 #289: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5316:
 +ixgbevf_recv_pkts_fake(void __rte_unused *rx_queue,
                                           ^
   
   ERROR: need consistent spacing around '*' (ctx:WxO)
   #290: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5317:
   +       struct rte_mbuf __rte_unused **rx_pkts,
                                    ^

ERROR: need consistent spacing around '*' (ctx:WxV)
#300: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5327:
+ixgbevf_xmit_pkts_fake(void __rte_unused *tx_queue,
                                          ^
  
  ERROR: need consistent spacing around '*' (ctx:WxO)
  #301: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:5328:
  +       struct rte_mbuf __rte_unused **tx_pkts,
                                    ^

total: 4 errors, 3 warnings, 246 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v4-4-8-ixgbe-implement-device-reset-on-VF.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


patch file error:
13297: 
patching file doc/guides/rel_notes/release_16_07.rst
Hunk #1 succeeded at 59 with fuzz 2 (offset 6 lines).
patching file drivers/net/e1000/e1000_ethdev.h patching file drivers/net/e1000/igb_ethdev.c Hunk #1 FAILED at 268.
Hunk #2 succeeded at 400 (offset -9 lines).
Hunk #3 FAILED at 2664.
2 out of 3 hunks FAILED -- saving rejects to file drivers/net/e1000/igb_ethdev.c.rej
patching file drivers/net/e1000/igb_rxtx.c

13295: 
patching file doc/guides/rel_notes/release_16_07.rst
Hunk #1 succeeded at 59 with fuzz 2 (offset 6 lines).
patching file drivers/net/ixgbe/ixgbe_ethdev.c Hunk #1 succeeded at 378 (offset -3 lines).
Hunk #2 succeeded at 585 (offset -3 lines).
Hunk #3 succeeded at 4048 (offset -15 lines).
Hunk #4 FAILED at 7197.
1 out of 4 hunks FAILED -- saving rejects to file drivers/net/ixgbe/ixgbe_ethdev.c.rej
patching file drivers/net/ixgbe/ixgbe_ethdev.h patching file drivers/net/ixgbe/ixgbe_rxtx.c

DPDK STV team 


More information about the test-report mailing list