[dpdk-test-report] |WARNING| [PATCH 17/56] net/sfc: import libefx PHY LEDs control support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:02:46 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17114

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#126: FILE: drivers/net/sfc/efx/base/efx.h:476:
+extern	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#210: FILE: drivers/net/sfc/efx/base/efx_phy.c:143:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#232: FILE: drivers/net/sfc/efx/base/efx_phy.c:165:
+	if ((rc = epop->epo_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#236: FILE: drivers/net/sfc/efx/base/efx_phy.c:169:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#243: FILE: drivers/net/sfc/efx/base/efx_phy.c:176:
+	return (rc);

total: 3 errors, 0 warnings, 2 checks, 168 lines checked


More information about the test-report mailing list