[dpdk-test-report] |WARNING| [PATCH 24/56] net/sfc: import libefx support to access monitors via MCDI

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:14:54 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17141

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <MCDI_MON_PORT_Px>
#245: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:48:
+#define	MCDI_MON_PORT_Px	(0xFFFF)

CHECK:CAMELCASE: Avoid CamelCase: <Px>
#268: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:71:
+	STAT(Px, INT_TEMP),		/* 0x00 CONTROLLER_TEMP */

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_field' may be better as '(_field)' to avoid precedence issues
#359: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:162:
+#define	MCDI_STATIC_SENSOR_ASSERT(_field)				\
+	EFX_STATIC_ASSERT(MC_CMD_SENSOR_STATE_ ## _field		\
+			    == EFX_MON_STAT_STATE_ ## _field)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#372: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:175:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#387: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:190:
+	EFX_STATIC_ASSERT(sizeof (stat_mask[0]) * 8 ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#395: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:198:
+	memset(stat_mask, 0, sizeof (stat_mask));

WARNING:BRACES: braces {} are not necessary for single statement blocks
#449: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:252:
+	if (stat_maskp != NULL) {
+		memcpy(stat_maskp, stat_mask, sizeof (stat_mask));
+	}

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#450: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:253:
+		memcpy(stat_maskp, stat_mask, sizeof (stat_mask));

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#454: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:257:
+	__checkReturn			efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#461: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:264:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#462: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:265:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#491: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:294:
+		return (ENODEV);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENODEV)
#491: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:294:
+		return (ENODEV);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#498: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:301:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#503: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:306:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#533: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:336:
+	return (req.emr_rc);

CHECK:SPACING: No space is necessary after a cast
#551: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:354:
+		(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#551: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:354:
+		(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#571: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:374:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#576: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:379:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#596: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:399:
+		(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#596: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:399:
+		(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#627: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:430:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#636: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:439:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#645: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:448:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#649: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:452:
+	if ((rc = efx_mcdi_read_sensors(enp, esmp, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#659: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:462:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#664: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:467:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#671: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:474:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#698: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:501:
+	if ((rc = efx_mcdi_sensor_info_npages(enp, &npages)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#702: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:505:
+	encp->enc_mcdi_sensor_mask_size = npages * sizeof (uint32_t);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#715: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:518:
+	if ((rc = efx_mcdi_sensor_info(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#726: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:529:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#743: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:546:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#750: FILE: drivers/net/sfc/efx/base/mcdi_mon.c:553:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#814: FILE: drivers/net/sfc/efx/base/mcdi_mon.h:46:
+    __in^I^Iefx_nic_t *enp);$

total: 15 errors, 9 warnings, 12 checks, 724 lines checked


More information about the test-report mailing list