[dpdk-test-report] |WARNING| [PATCH v2 17/55] net/sfc: import libefx PHY LEDs control support
checkpatch at dpdk.org
checkpatch at dpdk.org
Tue Nov 29 17:21:33 CET 2016
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17285
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#134: FILE: drivers/net/sfc/base/efx.h:476:
+extern __checkReturn efx_rc_t
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#218: FILE: drivers/net/sfc/base/efx_phy.c:143:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#240: FILE: drivers/net/sfc/base/efx_phy.c:165:
+ if ((rc = epop->epo_reconfigure(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#244: FILE: drivers/net/sfc/base/efx_phy.c:169:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#251: FILE: drivers/net/sfc/base/efx_phy.c:176:
+ return (rc);
total: 3 errors, 0 warnings, 2 checks, 168 lines checked
More information about the test-report
mailing list