[dpdk-test-report] |WARNING| pw27611 [PATCH] kni: fix build on SLE12 SP3

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Aug 15 11:58:37 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27611

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#34: FILE: lib/librte_eal/linuxapp/kni/compat.h:13:
+#define SLE_VERSION(a,b,c) KERNEL_VERSION(a,b,c)
                      ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#34: FILE: lib/librte_eal/linuxapp/kni/compat.h:13:
+#define SLE_VERSION(a,b,c) KERNEL_VERSION(a,b,c)
                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#34: FILE: lib/librte_eal/linuxapp/kni/compat.h:13:
+#define SLE_VERSION(a,b,c) KERNEL_VERSION(a,b,c)
                                            ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#34: FILE: lib/librte_eal/linuxapp/kni/compat.h:13:
+#define SLE_VERSION(a,b,c) KERNEL_VERSION(a,b,c)
                                              ^

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#37: FILE: lib/librte_eal/linuxapp/kni/compat.h:16:
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))

ERROR:SPACING: space required after that ',' (ctx:VxV)
#40: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#40: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
                                                  ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#40: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#40: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#40: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )

ERROR:SPACING: space required after that ',' (ctx:VxV)
#42: FILE: lib/librte_eal/linuxapp/kni/compat.h:21:
+#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#42: FILE: lib/librte_eal/linuxapp/kni/compat.h:21:
+#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#43: FILE: lib/librte_eal/linuxapp/kni/compat.h:22:
+#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3,0,61)) && \
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#43: FILE: lib/librte_eal/linuxapp/kni/compat.h:22:
+#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3,0,61)) && \
                                                 ^

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#43: FILE: lib/librte_eal/linuxapp/kni/compat.h:22:
+#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3,0,61)) && \

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#44: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+       (LINUX_VERSION_CODE < KERNEL_VERSION(3,1,0)))$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#44: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+       (LINUX_VERSION_CODE < KERNEL_VERSION(3,1,0)))
                                              ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#44: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+       (LINUX_VERSION_CODE < KERNEL_VERSION(3,1,0)))
                                                ^

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#44: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+       (LINUX_VERSION_CODE < KERNEL_VERSION(3,1,0)))

ERROR:SPACING: space required after that ',' (ctx:VxV)
#46: FILE: lib/librte_eal/linuxapp/kni/compat.h:25:
+#define SLE_VERSION_CODE SLE_VERSION(11,3,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#46: FILE: lib/librte_eal/linuxapp/kni/compat.h:25:
+#define SLE_VERSION_CODE SLE_VERSION(11,3,0)
                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#47: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#47: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
                                                 ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#47: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#47: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#47: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )

ERROR:SPACING: space required after that ',' (ctx:VxV)
#49: FILE: lib/librte_eal/linuxapp/kni/compat.h:28:
+#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#49: FILE: lib/librte_eal/linuxapp/kni/compat.h:28:
+#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#50: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#50: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
                                                 ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#50: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#50: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#50: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )

ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: lib/librte_eal/linuxapp/kni/compat.h:31:
+#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: lib/librte_eal/linuxapp/kni/compat.h:31:
+#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
                                          ^

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#68: FILE: lib/librte_eal/linuxapp/kni/compat.h:86:
+	 RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)) || \

ERROR:SPACING: space required after that ',' (ctx:VxV)
#70: FILE: lib/librte_eal/linuxapp/kni/compat.h:88:
+	  SLE_VERSION_CODE == SLE_VERSION(12,3,0))
 	                                    ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#70: FILE: lib/librte_eal/linuxapp/kni/compat.h:88:
+	  SLE_VERSION_CODE == SLE_VERSION(12,3,0))
 	                                      ^

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#70: FILE: lib/librte_eal/linuxapp/kni/compat.h:88:
+	  SLE_VERSION_CODE == SLE_VERSION(12,3,0))

total: 30 errors, 9 warnings, 44 lines checked


More information about the test-report mailing list