[dpdk-test-report] |WARNING| pw32270 [PATCH v2 01/11] eal: add common test assert macros
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Dec 14 16:02:31 CET 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32270
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#84: FILE: lib/librte_eal/common/include/rte_test.h:38:
+#define RTE_TEST_ASSERT(cond, msg, ...) do { \
+ if (!(cond)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#92: FILE: lib/librte_eal/common/include/rte_test.h:46:
+#define RTE_TEST_ASSERT_EQUAL(a, b, msg, ...) do { \
+ if (!(a == b)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#100: FILE: lib/librte_eal/common/include/rte_test.h:54:
+#define RTE_TEST_ASSERT_NOT_EQUAL(a, b, msg, ...) do { \
+ if (!(a != b)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#108: FILE: lib/librte_eal/common/include/rte_test.h:62:
+#define RTE_TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+ typeof(val) _val = (val); \
+ if (!(_val == 0)) { \
+ RTE_LOG(DEBUG, EAL, \
+ "Test assert %s line %d failed (err %d): " \
+ msg "
", __func__, __LINE__, _val, \
+ ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#119: FILE: lib/librte_eal/common/include/rte_test.h:73:
+#define RTE_TEST_ASSERT_FAIL(val, msg, ...) do { \
+ if (!(val != 0)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#127: FILE: lib/librte_eal/common/include/rte_test.h:81:
+#define RTE_TEST_ASSERT_NULL(val, msg, ...) do { \
+ if (!(val == NULL)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#135: FILE: lib/librte_eal/common/include/rte_test.h:89:
+#define RTE_TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+ if (!(val != NULL)) { \
+ RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: " \
+ msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+ return -1; \
+ } \
+} while (0)
total: 0 errors, 7 warnings, 105 lines checked
More information about the test-report
mailing list