[dpdk-test-report] |WARNING| pw32399 [PATCH 10/11] qede: implement dynamic logging

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Dec 19 07:40:47 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32399

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_dev' - possible side-effects?
#83: FILE: drivers/net/qede/qede_logs.h:14:
+#define DP_ERR(p_dev, fmt, ...)				\
+	rte_log(RTE_LOG_ERR, qede_logtype_driver,	\
+		"[%s:%d(%s)]" fmt,			\
+		__func__, __LINE__,			\
+		(p_dev)->name ? (p_dev)->name : "",	\
 		##__VA_ARGS__)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_dev' - possible side-effects?
#131: FILE: drivers/net/qede/qede_logs.h:48:
+#define DP_VERBOSE(p_dev, module, fmt, ...)				\
+	do {								\
+		if ((p_dev)->dp_module & module)			\
+			rte_log(RTE_LOG_DEBUG, qede_logtype_driver,	\
+				"[%s:%d(%s)]" fmt,			\
+				__func__, __LINE__,			\
+				(p_dev)->name ? (p_dev)->name : "",	\
+				##__VA_ARGS__);				\
+	} while (0)

total: 0 errors, 0 warnings, 2 checks, 117 lines checked


More information about the test-report mailing list