[dpdk-test-report] |WARNING| pw32657 [PATCH v4 4/5] bbdev: test applications

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Dec 23 01:52:53 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32657

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#70: FILE: MAINTAINERS:279:
+F: app/test-bbdev

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#73: FILE: MAINTAINERS:282:
+F: doc/guides/tools/testbbdev.rst

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#477: FILE: app/test-bbdev/main.h:23:
+#define TEST_ASSERT(cond, msg, ...) do {  \
+		if (!(cond)) {  \
+			printf("TestCase %s() line %d failed: " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#486: FILE: app/test-bbdev/main.h:32:
+#define TEST_ASSERT_BUFFERS_ARE_EQUAL(a, b, len, msg, ...) do { \
+	if (memcmp((a), (b), len)) { \
+		printf("TestCase %s() line %d failed: " \
+			msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+		rte_memdump(stdout, "Buffer A", (a), len); \
+		rte_memdump(stdout, "Buffer B", (b), len); \
+		return TEST_FAILED; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#496: FILE: app/test-bbdev/main.h:42:
+#define TEST_ASSERT_SUCCESS(val, msg, ...) do { \
+		typeof(val) _val = (val); \
+		if (!(_val == 0)) { \
+			printf("TestCase %s() line %d failed (err %d): " \
+				msg "
", __func__, __LINE__, _val, \
+				##__VA_ARGS__); \
+			return TEST_FAILED; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#509: FILE: app/test-bbdev/main.h:55:
+#define TEST_ASSERT_NOT_NULL(val, msg, ...) do { \
+		if ((val) == NULL) { \
+			printf("TestCase %s() line %d failed (null): " \
+				msg "
", __func__, __LINE__, ##__VA_ARGS__); \
+			return TEST_FAILED;  \
+		} \
+} while (0)

total: 0 errors, 6 warnings, 5848 lines checked


More information about the test-report mailing list