[dpdk-test-report] |WARNING| pw32780 [PATCH v2 1/2] net/tap: add eBPF instructions to TAP device

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Dec 28 11:10:02 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32780

_coding style issues_


CHECK:ARCH_DEFINES: architecture specific defines should be avoided
#815: FILE: drivers/net/tap/tap_bpf_insns.c:614:
+# if defined(__i386__)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#957: FILE: drivers/net/tap/tap_bpf_program.c:51:
+#define IPv4(a, b, c, d) ((__u32)(((a) & 0xff) << 24) | \

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(a)
#1128: FILE: drivers/net/tap/tap_flow.h:53:
+#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#1128: FILE: drivers/net/tap/tap_flow.h:53:
+#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))

total: 0 errors, 1 warnings, 3 checks, 1054 lines checked


More information about the test-report mailing list