[dpdk-test-report] |WARNING| pw26534 [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jul 6 15:16:38 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26534

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#339: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:253:
+				       const struct rte_event_eth_rx_adapter_queue_conf *conf);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#916: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:523:
+	unsigned sz;

WARNING:LONG_LINE: line over 90 characters
#940: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:547:
+	rss_key_be = (void *)&rte_event_eth_rx_adapter[RTE_MAX_EVENT_ETH_RX_ADAPTER_INSTANCE];

WARNING:BRACES: braces {} are not necessary for single statement blocks
#960: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:567:
+	if (rte_event_eth_rx_adapter[id]) {
+		return -EEXIST;
+	}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#1041: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:648:
+	for (i = 0; i < rte_eth_dev_count(); i++)
+			rte_free(rx_adapter->eth_devices[i].rx_queue);

WARNING:LONG_LINE: line over 90 characters
#1075: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:682:
+				    const struct rte_event_eth_rx_adapter_queue_conf *conf)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'conf->rx_queue_flags'
#1103: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:710:
+	if (conf->
+	    rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {

total: 0 errors, 7 warnings, 1164 lines checked


More information about the test-report mailing list