[dpdk-test-report] |WARNING| pw25441 [PATCH] ether: add support for vtune task tracing

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Jun 19 19:20:40 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25441

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21: 
and header on his machine and re-build DPDK with additional make parameters:

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#82: FILE: lib/librte_ether/rte_eth_itt.h:18:
+	__itt_domain *wasted_iteration_itt_domains[RTE_MAX_QUEUES_PER_PORT];
 	             ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#86: FILE: lib/librte_ether/rte_eth_itt.h:22:
+	__itt_string_handle *wasted_iteration_itt_handles[RTE_MAX_QUEUES_PER_PORT];
 	                    ^

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#144: FILE: lib/librte_ether/rte_ethdev.c:823:
+	/**
+	* See rte_eth_itt.h to find comments on code below.

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#173: FILE: lib/librte_ether/rte_ethdev.h:2719:
+	/**
+	* See rte_eth_itt.h to find comments on code below.

WARNING:LONG_LINE: line over 90 characters
#178: FILE: lib/librte_ether/rte_ethdev.h:2724:
+				itt_aux_data[port_id].wasted_iteration_itt_domains[queue_id],

WARNING:LONG_LINE: line over 90 characters
#180: FILE: lib/librte_ether/rte_ethdev.h:2726:
+				itt_aux_data[port_id].wasted_iteration_itt_handles[queue_id]);

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#184: FILE: lib/librte_ether/rte_ethdev.h:2730:
+	}
+	else {

WARNING:LONG_LINE: line over 90 characters
#185: FILE: lib/librte_ether/rte_ethdev.h:2731:
+		if (unlikely(itt_aux_data[port_id].queue_is_wasting_iterations[queue_id])) {

WARNING:LONG_LINE: line over 90 characters
#187: FILE: lib/librte_ether/rte_ethdev.h:2733:
+				itt_aux_data[port_id].wasted_iteration_itt_domains[queue_id]);

total: 3 errors, 7 warnings, 133 lines checked


More information about the test-report mailing list