[dpdk-test-report] |WARNING| pw25902 [PATCH 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Jun 29 23:56:13 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25902

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#189: FILE: drivers/net/mlx5/mlx5_rxq.c:663:
+			return ENOMEM;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txq *' should also have an identifier name
#675: FILE: drivers/net/mlx5/mlx5_rxtx.h:349:
+int txq_check_vec_tx_support(struct txq *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#676: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+int priv_check_raw_vec_tx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#677: FILE: drivers/net/mlx5/mlx5_rxtx.h:351:
+int priv_check_vec_tx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rxq *' should also have an identifier name
#678: FILE: drivers/net/mlx5/mlx5_rxtx.h:352:
+int rxq_check_vec_rx_support(struct rxq *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#679: FILE: drivers/net/mlx5/mlx5_rxtx.h:353:
+int priv_check_vec_rx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#680: FILE: drivers/net/mlx5/mlx5_rxtx.h:354:
+void priv_prep_vec_rx_function(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#681: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#681: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#681: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#682: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#682: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#682: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#683: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#683: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#683: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1052: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.c:88:
+txq_wr_dseg_v(struct txq *txq, __m128i *dseg,
                                        ^

total: 0 errors, 16 warnings, 1 checks, 2336 lines checked


More information about the test-report mailing list