[dpdk-test-report] |WARNING| pw21230 [PATCH] PPP prototype

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 3 08:27:58 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21230

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: app/test-pmd/config.c:3286:
+                printf("%s: File operations failed
", __func__);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: app/test-pmd/config.c:3286:
+                printf("%s: File operations failed
", __func__);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#189: FILE: app/test-pmd/config.c:3289:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: app/test-pmd/config.c:3289:
+        }$

ERROR:SPACING: space required before the open parenthesis '('
#192: FILE: app/test-pmd/config.c:3292:
+	for(uint32_t i = 0; i < pkg_size; i++) {

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#208: FILE: app/test-pmd/config.c:3308:
+/* ^Iint fd = STDOUT_FILENO; */$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#224: FILE: app/test-pmd/config.c:3324:
+/*                 dprintf(fd, "not enough memory to load %u bytes
", (uint32_t)stf.st_size); */

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#249: FILE: app/test-pmd/config.c:3349:
+/* ^Ireturn buf; */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#285: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:202:
+        i40e_aqc_opc_write_personalization_profile^I= 0x0270,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:202:
+        i40e_aqc_opc_write_personalization_profile^I= 0x0270,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:203:
+        i40e_aqc_opc_read_personalization_profile_list^I= 0x0271,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:203:
+        i40e_aqc_opc_read_personalization_profile_list^I= 0x0271,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#297: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1450:
+        u8      flags;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#297: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1450:
+        u8      flags;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#300: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1453:
+        u8      reserved[3];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1453:
+        u8      reserved[3];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#301: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1454:
+        __le32  profile_track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1454:
+        __le32  profile_track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#302: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1455:
+        __le32  addr_high;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1455:
+        __le32  addr_high;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#303: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1456:
+        __le32  addr_low;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#303: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1456:
+        __le32  addr_low;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#309: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1462:
+        __le32 error_offset;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1462:
+        __le32 error_offset;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#310: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1463:
+        __le32 error_info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1463:
+        __le32 error_info;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#311: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1464:
+        __le32 addr_high;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#311: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1464:
+        __le32 addr_high;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#312: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1465:
+        __le32 addr_low;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#312: FILE: drivers/net/i40e/base/i40e_adminq_cmd.h:1465:
+        __le32 addr_low;$

WARNING:LONG_LINE: line over 90 characters
#391: FILE: drivers/net/i40e/base/i40e_common.c:7054:
+	i40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_read_personalization_profile_list);

ERROR:CODE_INDENT: code indent should use tabs where possible
#429: FILE: drivers/net/i40e/base/i40e_common.c:7092:
+^I^I         pkg_hdr->segment_offset[i]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#623: FILE: drivers/net/i40e/i40e_ethdev.c:11228:
+        struct rte_eth_dev *dev = &rte_eth_devices[port];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#623: FILE: drivers/net/i40e/i40e_ethdev.c:11228:
+        struct rte_eth_dev *dev = &rte_eth_devices[port];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#625: FILE: drivers/net/i40e/i40e_ethdev.c:11230:
+        struct i40e_package_header *pkg_hdr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#625: FILE: drivers/net/i40e/i40e_ethdev.c:11230:
+        struct i40e_package_header *pkg_hdr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#626: FILE: drivers/net/i40e/i40e_ethdev.c:11231:
+        struct i40e_generic_seg_header *profile_seg_hdr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#626: FILE: drivers/net/i40e/i40e_ethdev.c:11231:
+        struct i40e_generic_seg_header *profile_seg_hdr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#627: FILE: drivers/net/i40e/i40e_ethdev.c:11232:
+        struct i40e_generic_seg_header *metadata_seg_hdr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#627: FILE: drivers/net/i40e/i40e_ethdev.c:11232:
+        struct i40e_generic_seg_header *metadata_seg_hdr;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#628: FILE: drivers/net/i40e/i40e_ethdev.c:11233:
+        uint32_t track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#628: FILE: drivers/net/i40e/i40e_ethdev.c:11233:
+        uint32_t track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#629: FILE: drivers/net/i40e/i40e_ethdev.c:11234:
+        enum i40e_status_code status;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#629: FILE: drivers/net/i40e/i40e_ethdev.c:11234:
+        enum i40e_status_code status;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#631: FILE: drivers/net/i40e/i40e_ethdev.c:11236:
+        pkg_hdr = (struct i40e_package_header *)buff;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#631: FILE: drivers/net/i40e/i40e_ethdev.c:11236:
+        pkg_hdr = (struct i40e_package_header *)buff;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#633: FILE: drivers/net/i40e/i40e_ethdev.c:11238:
+        if (!pkg_hdr) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#633: FILE: drivers/net/i40e/i40e_ethdev.c:11238:
+        if (!pkg_hdr) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#634: FILE: drivers/net/i40e/i40e_ethdev.c:11239:
+                PMD_DRV_LOG(ERR, "Failed to fill the package structure");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#634: FILE: drivers/net/i40e/i40e_ethdev.c:11239:
+                PMD_DRV_LOG(ERR, "Failed to fill the package structure");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#635: FILE: drivers/net/i40e/i40e_ethdev.c:11240:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#635: FILE: drivers/net/i40e/i40e_ethdev.c:11240:
+                return -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#636: FILE: drivers/net/i40e/i40e_ethdev.c:11241:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#636: FILE: drivers/net/i40e/i40e_ethdev.c:11241:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#638: FILE: drivers/net/i40e/i40e_ethdev.c:11243:
+        /* Find metadata segment */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#639: FILE: drivers/net/i40e/i40e_ethdev.c:11244:
+        metadata_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_METADATA,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#639: FILE: drivers/net/i40e/i40e_ethdev.c:11244:
+        metadata_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_METADATA,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#640: FILE: drivers/net/i40e/i40e_ethdev.c:11245:
+                                                        pkg_hdr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#640: FILE: drivers/net/i40e/i40e_ethdev.c:11245:
+                                                        pkg_hdr);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#641: FILE: drivers/net/i40e/i40e_ethdev.c:11246:
+        if (!metadata_seg_hdr) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#641: FILE: drivers/net/i40e/i40e_ethdev.c:11246:
+        if (!metadata_seg_hdr) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#642: FILE: drivers/net/i40e/i40e_ethdev.c:11247:
+                PMD_DRV_LOG(ERR, "Failed to find metadata segment header");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#642: FILE: drivers/net/i40e/i40e_ethdev.c:11247:
+                PMD_DRV_LOG(ERR, "Failed to find metadata segment header");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#643: FILE: drivers/net/i40e/i40e_ethdev.c:11248:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#643: FILE: drivers/net/i40e/i40e_ethdev.c:11248:
+                return -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#644: FILE: drivers/net/i40e/i40e_ethdev.c:11249:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#644: FILE: drivers/net/i40e/i40e_ethdev.c:11249:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#645: FILE: drivers/net/i40e/i40e_ethdev.c:11250:
+        track_id = ((struct i40e_metadata_segment *)metadata_seg_hdr)->track_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#645: FILE: drivers/net/i40e/i40e_ethdev.c:11250:
+        track_id = ((struct i40e_metadata_segment *)metadata_seg_hdr)->track_id;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#648: FILE: drivers/net/i40e/i40e_ethdev.c:11253:
+        profile_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_I40E,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#648: FILE: drivers/net/i40e/i40e_ethdev.c:11253:
+        profile_seg_hdr = i40e_find_segment_in_package(SEGMENT_TYPE_I40E,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#649: FILE: drivers/net/i40e/i40e_ethdev.c:11254:
+                                                       pkg_hdr);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#649: FILE: drivers/net/i40e/i40e_ethdev.c:11254:
+                                                       pkg_hdr);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#650: FILE: drivers/net/i40e/i40e_ethdev.c:11255:
+        if (!profile_seg_hdr) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#650: FILE: drivers/net/i40e/i40e_ethdev.c:11255:
+        if (!profile_seg_hdr) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#651: FILE: drivers/net/i40e/i40e_ethdev.c:11256:
+                PMD_DRV_LOG(ERR, "Failed to find profile segment header");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#651: FILE: drivers/net/i40e/i40e_ethdev.c:11256:
+                PMD_DRV_LOG(ERR, "Failed to find profile segment header");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#652: FILE: drivers/net/i40e/i40e_ethdev.c:11257:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#652: FILE: drivers/net/i40e/i40e_ethdev.c:11257:
+                return -EINVAL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#653: FILE: drivers/net/i40e/i40e_ethdev.c:11258:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#653: FILE: drivers/net/i40e/i40e_ethdev.c:11258:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#655: FILE: drivers/net/i40e/i40e_ethdev.c:11260:
+        /* Write profile to HW */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#656: FILE: drivers/net/i40e/i40e_ethdev.c:11261:
+        status = i40e_write_profile(hw,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#656: FILE: drivers/net/i40e/i40e_ethdev.c:11261:
+        status = i40e_write_profile(hw,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#660: FILE: drivers/net/i40e/i40e_ethdev.c:11265:
+        if (!status)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#660: FILE: drivers/net/i40e/i40e_ethdev.c:11265:
+        if (!status)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#661: FILE: drivers/net/i40e/i40e_ethdev.c:11266:
+                printf("Write profile successfully.
");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#661: FILE: drivers/net/i40e/i40e_ethdev.c:11266:
+                printf("Write profile successfully.
");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#663: FILE: drivers/net/i40e/i40e_ethdev.c:11268:
+        return status;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#663: FILE: drivers/net/i40e/i40e_ethdev.c:11268:
+        return status;$

total: 45 errors, 45 warnings, 0 checks, 568 lines checked


More information about the test-report mailing list