[dpdk-test-report] |WARNING| pw21277 [PATCH] crypto/aesni_mb: process crypto operation in dequeue function

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Mar 3 11:16:05 CET 2017
Previous message: [dpdk-test-report] |SUCCESS| pw21276 [PATCH] app/pdump: fix pdump can't find the driver when compiled dpdk to shared libraries
Next message: [dpdk-test-report] |SUCCESS| pw21171 [PATCH 16/17] net/fm10k/base: replace macros
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21277

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#43: 
moving the crypto processing from the enqueue burst to the dequeue burst, to

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:326:
+       struct aesni_mb_qp *qp = __qp;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:328:
+       unsigned nb_enqueued;$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#130: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:328:
+       unsigned nb_enqueued;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#132: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:330:
+       nb_enqueued = rte_ring_enqueue_burst(qp->ingress_queue,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:331:
+                       (void **)ops, nb_ops);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:331:
+                       (void **)ops, nb_ops);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:333:
+       qp->stats.enqueued_count += nb_enqueued;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:335:
+       return nb_enqueued;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:588:
+^I               uint16_t nb_ops)$

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#338: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:593:
+	JOB_AES_HMAC * job = (*qp->op_fns->job.flush_job)(&qp->mb_mgr);

ERROR:CODE_INDENT: code indent should use tabs where possible
#361: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:614:
+               uint16_t nb_ops)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:614:
+               uint16_t nb_ops)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#516: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:345:
+               const char *str, unsigned ring_size, int socket_id)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#516: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:345:
+               const char *str, unsigned ring_size, int socket_id)$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#516: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:345:
+               const char *str, unsigned ring_size, int socket_id)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#517: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:346:
+ {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#518: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:347:
+        struct rte_ring *r;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#518: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:347:
+        struct rte_ring *r;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#519: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:348:
+       char ring_name[RTE_CRYPTODEV_NAME_LEN];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#521: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:350:
+       unsigned n = snprintf(ring_name, sizeof(ring_name),$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#521: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:350:
+       unsigned n = snprintf(ring_name, sizeof(ring_name),

ERROR:CODE_INDENT: code indent should use tabs where possible
#522: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:351:
+                       "%s_%s",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#522: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:351:
+                       "%s_%s",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#523: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:352:
+                       qp->name, str);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#523: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:352:
+                       qp->name, str);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#525: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:354:
+       if (n > sizeof(ring_name))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#525: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:354:
+       if (n > sizeof(ring_name))
+               return NULL;

ERROR:CODE_INDENT: code indent should use tabs where possible
#526: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:355:
+               return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#526: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:355:
+               return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#530: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:358:
+       r = rte_ring_lookup(ring_name);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#531: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:359:
+        if (r) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#531: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:359:
+        if (r) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#532: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:360:
+                if (r->prod.size >= ring_size) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#532: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:360:
+                if (r->prod.size >= ring_size) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#533: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:361:
+                        MB_LOG_INFO("Reusing existing ring %s for processed ops",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#533: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:361:
+                        MB_LOG_INFO("Reusing existing ring %s for processed ops",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#534: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:362:
+                                       ring_name);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#534: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:362:
+                                       ring_name);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#535: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:363:
+                        return r;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#535: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:363:
+                        return r;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#536: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:364:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#536: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:364:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#538: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:366:
+                MB_LOG_ERR("Unable to reuse existing ring %s for processed ops",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#538: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:366:
+                MB_LOG_ERR("Unable to reuse existing ring %s for processed ops",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#539: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:367:
+                               ring_name);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#539: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:367:
+                               ring_name);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#540: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:368:
+                return NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#540: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:368:
+                return NULL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#541: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:369:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#541: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:369:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#543: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:371:
+       return rte_ring_create(ring_name, ring_size, socket_id,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#562: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:406:
+                goto qp_setup_cleanup;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#562: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c:406:
+                goto qp_setup_cleanup;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#590: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h:158:
+       struct rte_ring *ingress_queue;$

total: 20 errors, 35 warnings, 513 lines checked
Previous message: [dpdk-test-report] |SUCCESS| pw21276 [PATCH] app/pdump: fix pdump can't find the driver when compiled dpdk to shared libraries
Next message: [dpdk-test-report] |SUCCESS| pw21171 [PATCH 16/17] net/fm10k/base: replace macros
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list