[dpdk-test-report] |WARNING| pw21620 [PATCH v2 06/13] net/failsafe: add fail-safe PMD

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21620

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#502: FILE: drivers/net/failsafe/failsafe.c:84:
+		const unsigned socket_id,

CHECK:CAMELCASE: Avoid CamelCase: <eal_parse_pci_DomBDF>
#755: FILE: drivers/net/failsafe/failsafe_args.c:102:
+	    eal_parse_pci_DomBDF(args, &d->pci.addr) == 0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#914: FILE: drivers/net/failsafe/failsafe_args.c:261:
+	unsigned arg_count;

WARNING:LONG_LINE_STRING: line over 90 characters
#1501: FILE: drivers/net/failsafe/failsafe_ops.c:171:
+			ERROR("Operation rte_eth_dev_set_link_down failed for sub_device %d"

WARNING:LONG_LINE_STRING: line over 90 characters
#1928: FILE: drivers/net/failsafe/failsafe_ops.c:598:
+			ERROR("Operation rte_eth_dev_flow_ctrl_set failed for sub_device %d"

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#2173: FILE: drivers/net/failsafe/failsafe_private.h:160:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#2173: FILE: drivers/net/failsafe/failsafe_private.h:160:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#2173: FILE: drivers/net/failsafe/failsafe_private.h:160:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#2192: FILE: drivers/net/failsafe/failsafe_private.h:179:
+#define TX_SUBDEV(dev)							  \
+	(PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail		   ? NULL \
+	 : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \
+	 : &PRIV(dev)->subs[PRIV(dev)->subs_tx]))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues
#2201: FILE: drivers/net/failsafe/failsafe_private.h:188:
+#define SUBOPS(s, ops) \
+	(ETH(s)->dev_ops->ops)

total: 0 errors, 4 warnings, 2182 lines checked